Skip to content

[#1623] Fix display of badges and use of flag for edge case of Liquid Glass setup#1624

Merged
pylapp merged 2 commits into
developfrom
1623-for-toolbar-top-with-badges-on-items-on-liquid-glass-disabled-app-on-ios-27-badges-are-no-displayed
Jul 15, 2026
Merged

[#1623] Fix display of badges and use of flag for edge case of Liquid Glass setup#1624
pylapp merged 2 commits into
developfrom
1623-for-toolbar-top-with-badges-on-items-on-liquid-glass-disabled-app-on-ios-27-badges-are-no-displayed

Conversation

@pylapp

@pylapp pylapp commented Jul 15, 2026

Copy link
Copy Markdown
Member

Related issues

#1623

Description

For top toolbar check flag for forced legacy layout to display badges.
Rename also dedicated flag and view modifier which are not now targeting only tab bar.
Update components to to check both Liquid Glass status and forced legacy layout status.

Motivation & Context

Fix missing badges for top toolbar, and manage in all cases the edge case where legacy layout has been forced.

Types of change

  • Breaking change (fix or feature that would change existing functionality)

Previews

Checklist

Contribution

Accessibility

  • (NA) My change follows accessibility good practices

Design

  • (NA) My change respects the design guidelines of Orange Unified Design System

Development

  • My change follows the developer guide
  • I checked my changes do not add new SwiftLint warnings
  • I have added unit tests to cover my changes (optional)

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • The evolution have been tested and the project builds for iPhones and iPads
  • Code review has been done by reviewers according to CODEOWNERS file
  • (NA) Design review has been done
  • (NA) Accessibility review has been done
  • (NA) Q/A team has tested the evolution
  • Documentation has been updated if relevant
  • Internal files have been updated if relevant (like CONTRIBUTING, DEVELOP, THIRD_PARTY, CONTRIBUTORS, NOTICE)
  • CHANGELOG has been updated respecting keep a changelog rules and reference the issues
  • The wiki has been updated if needed (optional)

…Glass setup (#1623)

Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses missing badge rendering in the top toolbar when Liquid Glass is disabled on iOS 27 (notably when legacy layout is forced), and renames the “legacy tab bar” forcing flag/modifier to reflect its broader scope across navigation elements.

Changes:

  • Update toolbar item rendering (including badges) to use legacy layout when either Liquid Glass is disabled or legacy layout is explicitly forced.
  • Rename the environment flag/modifier from tab-bar-specific naming to broader “legacy layout” naming across navigation components.
  • Update migration/documentation/changelog to reflect the rename and the iOS 27 + Xcode 26 edge case.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
skills/ouds-ios-migration/SKILL.md Documents the rename (forceOUDSLegacyTabBarforceOUDSLegacyLayout) in the migration skill.
OUDS/Core/Components/Sources/Navigations/ToolBar/Internal/ToolBarItems.swift Uses forceOUDSLegacyLayout to ensure correct label/badge rendering in legacy layout cases.
OUDS/Core/Components/Sources/Navigations/ToolBar/Internal/ToolBarItemModifiers.swift Applies legacy styling when Liquid Glass is disabled or legacy layout is forced.
OUDS/Core/Components/Sources/Navigations/ToolBar/Internal/NavigationStackRefresher.swift Refreshes navigation bar appearance using legacy configuration when legacy layout is forced.
OUDS/Core/Components/Sources/Navigations/TabBar/OUDSTabBarViewModifier.swift Renames environment flag usage to forceOUDSLegacyLayout for tab bar appearance decisions.
OUDS/Core/Components/Sources/Navigations/TabBar/OUDSTabBar.swift Renames environment flag usage and preserves behavior for legacy layout computations.
OUDS/Core/Components/Sources/_/ViewModifiers/LayoutModifiers/OUDSLegacyLayoutModifier.swift Introduces the renamed modifier/environment value for forcing legacy layout.
MIGRATION.md Adds migration guidance for the rename.
CHANGELOG.md Notes the fix and documents the breaking rename/removal.
Comments suppressed due to low confidence (3)

OUDS/Core/Components/Sources/_/ViewModifiers/LayoutModifiers/OUDSLegacyLayoutModifier.swift:63

  • The migration docs instruct users to call .forceOUDSLegacyLayout(), but there is no View extension providing that API (only OUDSLegacyLayoutModifier). This creates a public-API/documentation mismatch and makes the rename guidance incomplete. Consider adding a View.forceOUDSLegacyLayout() helper and updating the EnvironmentValues doc comment to match the broader scope (not tab bar-specific).
    OUDS/Core/Components/Sources/_/ViewModifiers/LayoutModifiers/OUDSLegacyLayoutModifier.swift:24
  • Doc comment has a few typos/grammar issues ("wether", "stils") and an unclear sentence that could confuse when this modifier is needed.
    OUDS/Core/Components/Sources/_/ViewModifiers/LayoutModifiers/OUDSLegacyLayoutModifier.swift:55
  • This comment still references "legacy tab bar" even though the modifier/environment value is now broader (used by toolbars/nav bars too). Updating wording helps avoid confusion for API consumers.

Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated
Comment thread MIGRATION.md Outdated
Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
@pylapp pylapp merged commit 8108df5 into develop Jul 15, 2026
16 of 17 checks passed
@pylapp pylapp deleted the 1623-for-toolbar-top-with-badges-on-items-on-liquid-glass-disabled-app-on-ios-27-badges-are-no-displayed branch July 15, 2026 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

For toolbar top with badges on items on Liquid Glass disabled app on iOS 27, badges are no displayed

2 participants