Conversation
…Glass setup (#1623) Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
3 tasks
There was a problem hiding this comment.
Pull request overview
This PR addresses missing badge rendering in the top toolbar when Liquid Glass is disabled on iOS 27 (notably when legacy layout is forced), and renames the “legacy tab bar” forcing flag/modifier to reflect its broader scope across navigation elements.
Changes:
- Update toolbar item rendering (including badges) to use legacy layout when either Liquid Glass is disabled or legacy layout is explicitly forced.
- Rename the environment flag/modifier from tab-bar-specific naming to broader “legacy layout” naming across navigation components.
- Update migration/documentation/changelog to reflect the rename and the iOS 27 + Xcode 26 edge case.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| skills/ouds-ios-migration/SKILL.md | Documents the rename (forceOUDSLegacyTabBar → forceOUDSLegacyLayout) in the migration skill. |
| OUDS/Core/Components/Sources/Navigations/ToolBar/Internal/ToolBarItems.swift | Uses forceOUDSLegacyLayout to ensure correct label/badge rendering in legacy layout cases. |
| OUDS/Core/Components/Sources/Navigations/ToolBar/Internal/ToolBarItemModifiers.swift | Applies legacy styling when Liquid Glass is disabled or legacy layout is forced. |
| OUDS/Core/Components/Sources/Navigations/ToolBar/Internal/NavigationStackRefresher.swift | Refreshes navigation bar appearance using legacy configuration when legacy layout is forced. |
| OUDS/Core/Components/Sources/Navigations/TabBar/OUDSTabBarViewModifier.swift | Renames environment flag usage to forceOUDSLegacyLayout for tab bar appearance decisions. |
| OUDS/Core/Components/Sources/Navigations/TabBar/OUDSTabBar.swift | Renames environment flag usage and preserves behavior for legacy layout computations. |
| OUDS/Core/Components/Sources/_/ViewModifiers/LayoutModifiers/OUDSLegacyLayoutModifier.swift | Introduces the renamed modifier/environment value for forcing legacy layout. |
| MIGRATION.md | Adds migration guidance for the rename. |
| CHANGELOG.md | Notes the fix and documents the breaking rename/removal. |
Comments suppressed due to low confidence (3)
OUDS/Core/Components/Sources/_/ViewModifiers/LayoutModifiers/OUDSLegacyLayoutModifier.swift:63
- The migration docs instruct users to call
.forceOUDSLegacyLayout(), but there is noViewextension providing that API (onlyOUDSLegacyLayoutModifier). This creates a public-API/documentation mismatch and makes the rename guidance incomplete. Consider adding aView.forceOUDSLegacyLayout()helper and updating the EnvironmentValues doc comment to match the broader scope (not tab bar-specific).
OUDS/Core/Components/Sources/_/ViewModifiers/LayoutModifiers/OUDSLegacyLayoutModifier.swift:24 - Doc comment has a few typos/grammar issues ("wether", "stils") and an unclear sentence that could confuse when this modifier is needed.
OUDS/Core/Components/Sources/_/ViewModifiers/LayoutModifiers/OUDSLegacyLayoutModifier.swift:55 - This comment still references "legacy tab bar" even though the modifier/environment value is now broader (used by toolbars/nav bars too). Updating wording helps avoid confusion for API consumers.
Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
#1623
Description
For top toolbar check flag for forced legacy layout to display badges.
Rename also dedicated flag and view modifier which are not now targeting only tab bar.
Update components to to check both Liquid Glass status and forced legacy layout status.
Motivation & Context
Fix missing badges for top toolbar, and manage in all cases the edge case where legacy layout has been forced.
Types of change
Previews
Checklist
Contribution
Accessibility
Design
Development
Documentation
Checklist (for Core Team only)