Add configuration to skip AllOrNoneAsync.

Author: sarahelsaig

src/Modules/OrchardCore.Commerce.Tax/Drivers/TaxSettingsDisplayDriver.cs

@@ -0,0 +1,71 @@
+#nullable enable
+
+using Microsoft.AspNetCore.Authorization;
+using Microsoft.AspNetCore.Http;
+using OrchardCore.Commerce.Tax.Models;
+using OrchardCore.Commerce.Tax.Permissions;
+using OrchardCore.DisplayManagement.Entities;
+using OrchardCore.DisplayManagement.Handlers;
+using OrchardCore.DisplayManagement.Views;
+using OrchardCore.Environment.Shell;
+using OrchardCore.Settings;
+using System.Threading.Tasks;
+namespace OrchardCore.Commerce.Tax.Drivers;
+
+public class TaxSettingsDisplayDriver : SiteDisplayDriver<TaxSettings>
+{
+    public const string GroupId = nameof(TaxSettings);
+
+    private readonly IShellHost _shellHost;
+    private readonly ShellSettings _shellSettings;
+    private readonly IHttpContextAccessor _hca;
+    private readonly IAuthorizationService _authorizationService;
+
+    public TaxSettingsDisplayDriver(
+        IShellHost shellHost,
+        ShellSettings shellSettings,
+        IHttpContextAccessor hca,
+        IAuthorizationService authorizationService)
+    {
+        _shellHost = shellHost;
+        _shellSettings = shellSettings;
+        _hca = hca;
+        _authorizationService = authorizationService;
+    }
+
+    protected override string SettingsGroupId => GroupId;
+
+    public override async Task<IDisplayResult?> EditAsync(ISite model, TaxSettings section, BuildEditorContext context)
+    {
+        if (!await AuthorizeAsync())
+        {
+            return null;
+        }
+
+        context.AddTenantReloadWarningWrapper();
+
+        return Initialize<TaxSettings>(
+                $"{nameof(TaxSettings)}_Edit",
+                model => model.IgnoreAllOrNone = section.IgnoreAllOrNone)
+            .PlaceInContent()
+            .OnGroup(SettingsGroupId);
+    }
+
+    public override async Task<IDisplayResult?> UpdateAsync(ISite model, TaxSettings section, UpdateEditorContext context)
+    {
+        if (!await AuthorizeAsync())
+        {
+            return null;
+        }
+
+        if (await context.CreateModelMaybeAsync<TaxSettings>(Prefix, AuthorizeAsync) is { } viewModel)
+        {
+            section.IgnoreAllOrNone = viewModel.IgnoreAllOrNone;
+        }
+
+        return await EditAsync(model, section, context);
+    }
+
+    private Task<bool> AuthorizeAsync() =>
+        _authorizationService.AuthorizeAsync(_hca.HttpContext?.User, TaxRatePermissions.ManageTaxSettings);
+}

src/Modules/OrchardCore.Commerce.Tax/Models/TaxSettings.cs

@@ -0,0 +1,6 @@
+namespace OrchardCore.Commerce.Tax.Models;
+
+public class TaxSettings
+{
+    public bool IgnoreAllOrNone { get; set; }
+}

src/Modules/OrchardCore.Commerce.Tax/Navigation/TaxSettingsAdminMenu.cs

@@ -0,0 +1,29 @@
+using Lombiq.HelpfulLibraries.OrchardCore.Navigation;
+using Microsoft.AspNetCore.Http;
+using Microsoft.Extensions.Localization;
+using OrchardCore.Commerce.Tax.Drivers;
+using OrchardCore.Commerce.Tax.Permissions;
+using OrchardCore.Navigation;
+
+namespace OrchardCore.Commerce.Tax.Navigation;
+
+public class TaxSettingsAdminMenu : AdminMenuNavigationProviderBase
+{
+    public TaxSettingsAdminMenu(IHttpContextAccessor hca, IStringLocalizer<TaxSettingsAdminMenu> stringLocalizer)
+        : base(hca, stringLocalizer)
+    {
+    }
+
+    protected override void Build(NavigationBuilder builder) =>
+        builder
+            .Add(T["Configuration"], configuration => configuration
+                .Add(T["Commerce"], commerce => commerce
+                    .Add(T["Tax"], T["Tax"], entry => entry
+                        .Action("Index", "Admin", new
+                        {
+                            area = "OrchardCore.Settings",
+                            groupId = TaxSettingsDisplayDriver.GroupId,
+                        })
+                        .Permission(TaxRatePermissions.ManageTaxSettings)
+                        .LocalNav())));
+}

src/Modules/OrchardCore.Commerce.Tax/Permissions/TaxRatePermissions.cs

@@ -8,6 +8,8 @@ public class TaxRatePermissions : AdminPermissionBase
 {
     public static readonly Permission ManageCustomTaxRates =
         new(nameof(ManageCustomTaxRates), "Manage Custom Tax Rates");
+    public static readonly Permission ManageTaxSettings =
+        new(nameof(ManageTaxSettings), "Manage Tax Settings");
 
-    protected override IEnumerable<Permission> AdminPermissions { get; } = [ManageCustomTaxRates];
+    protected override IEnumerable<Permission> AdminPermissions { get; } = [ManageCustomTaxRates, ManageTaxSettings];
 }

src/Modules/OrchardCore.Commerce.Tax/Startup.cs

@@ -20,9 +20,12 @@ public class Startup : StartupBase
 {
     public override void ConfigureServices(IServiceCollection services)
     {
+        services.AddScoped<IPermissionProvider, TaxRatePermissions>();
         services.AddTransient<IConfigureOptions<ResourceManagementOptions>, ResourceManagementOptionsConfiguration>();
         services.AddContentPart<TaxPart>()
             .WithMigration<TaxPartMigrations>();
+        services.AddSiteDisplayDriver<TaxSettingsDisplayDriver>();
+        services.AddScoped<INavigationProvider, TaxSettingsAdminMenu>();
     }
 }
 
@@ -31,7 +34,6 @@ public class CustomTaxRatesStartup : StartupBase
 {
     public override void ConfigureServices(IServiceCollection services)
     {
-        services.AddScoped<IPermissionProvider, TaxRatePermissions>();
         services.AddScoped<ITaxRateSettingsHeaderProvider, TaxRateSettingsDisplayDriver>();
         services.AddSiteDisplayDriver<TaxRateSettingsDisplayDriver>();
         services.AddTransient<IConfigureOptions<TaxRateSettings>, TaxRateSettingsConfiguration>();

src/Modules/OrchardCore.Commerce.Tax/Views/TaxSettings_Edit.cshtml

@@ -0,0 +1,9 @@
+@model OrchardCore.Commerce.Tax.Models.TaxSettings
+
+<div class="mb-3" asp-validation-class-for="IgnoreAllOrNone">
+    <div class="w-sm-75 w-md-50 w-lg-25 pe-md-3">
+        <input asp-for="IgnoreAllOrNone" type="checkbox" class="form-check-input content-preview-select" checked="@Model.IgnoreAllOrNone" />
+        <label asp-for="IgnoreAllOrNone" class="form-check-label">@T["Skip consistent applicability check"]</label>
+    </div>
+    <span class="hint">@T["If checked, the shop won't verify that every product in the cart has a valid Tax part. If you check this, you are responsible for verifying that all taxable product types have attached and correctly configured tax parts."]</span>
+</div>

src/Modules/OrchardCore.Commerce/Services/LocalTaxProvider.cs

@@ -4,6 +4,7 @@
 using OrchardCore.Commerce.MoneyDataType.Extensions;
 using OrchardCore.Commerce.Tax.Models;
 using OrchardCore.ContentManagement;
+using OrchardCore.Settings;
 using System.Collections.Generic;
 using System.Linq;
 using System.Threading.Tasks;
@@ -12,9 +13,13 @@ namespace OrchardCore.Commerce.Services;
 
 public class LocalTaxProvider : ITaxProvider
 {
+    private readonly ISiteService _siteService;
+
     // This is the simplest, lowest priority option and if anything else is applicable it should supersede this.
     public int Order => int.MaxValue;
 
+    public LocalTaxProvider(ISiteService siteService) => _siteService = siteService;
+
     public Task<PromotionAndTaxProviderContext> UpdateAsync(PromotionAndTaxProviderContext model)
     {
         var items = model.Items.AsList();
@@ -37,8 +42,9 @@ public Task<PromotionAndTaxProviderContext> UpdateAsync(PromotionAndTaxProviderC
         });
     }
 
-    public Task<bool> IsApplicableAsync(PromotionAndTaxProviderContext model) =>
-        ITaxProvider.AllOrNoneAsync(model, items => Task.FromResult(HasTaxRate(items)));
+    public async Task<bool> IsApplicableAsync(PromotionAndTaxProviderContext model) =>
+        (await _siteService.GetSettingsAsync<TaxSettings>())?.IgnoreAllOrNone == true ||
+        await ITaxProvider.AllOrNoneAsync(model, items => Task.FromResult(HasTaxRate(items)));
 
     private int HasTaxRate(IList<PromotionAndTaxProviderContextLineItem> items) => items
         .SelectWhere(item => item.Content.ContentItem.As<TaxPart>())

src/Modules/OrchardCore.Commerce/Services/TaxRateTaxProvider.cs

@@ -22,8 +22,7 @@ public class TaxRateTaxProvider : ITaxProvider
 
     public async Task<PromotionAndTaxProviderContext> UpdateAsync(PromotionAndTaxProviderContext model)
     {
-        var siteSettings = await _siteService.GetSiteSettingsAsync();
-        var taxRates = siteSettings.As<TaxRateSettings>();
+        var taxRates = await _siteService.GetSettingsAsync<TaxRateSettings>();
 
         var items = model.Items.AsList();
 
@@ -47,8 +46,9 @@ public async Task<PromotionAndTaxProviderContext> UpdateAsync(PromotionAndTaxPro
         return model with { Items = updatedItems };
     }
 
-    public Task<bool> IsApplicableAsync(PromotionAndTaxProviderContext model) =>
-        ITaxProvider.AllOrNoneAsync(model, async items =>
+    public async Task<bool> IsApplicableAsync(PromotionAndTaxProviderContext model) =>
+        (await _siteService.GetSettingsAsync<TaxSettings>())?.IgnoreAllOrNone == true ||
+        await ITaxProvider.AllOrNoneAsync(model, async items =>
         {
             var siteSettings = await _siteService.GetSiteSettingsAsync();
             var taxRates = siteSettings.As<TaxRateSettings>();