OSOE-754: Fix nullability warnings (#706)

* Fix nullability warnings.

* Update HL nuget version.

Author: sarahelsaig

Directory.Packages.props

@@ -8,7 +8,7 @@
          should use Orchard Core references for the latest patch version to pull all versions up in the final app. -->
     <OrchardCoreVersion>2.1.0</OrchardCoreVersion>
 
-    <LombiqHelpfulLibrariesVersion>12.5.0</LombiqHelpfulLibrariesVersion>
+    <LombiqHelpfulLibrariesVersion>12.5.1-alpha.1.osoe-754</LombiqHelpfulLibrariesVersion>
     <LombiqTestsUIVersion>14.2.0</LombiqTestsUIVersion>
   </PropertyGroup>
 

src/Modules/OrchardCore.Commerce.Payment/Controllers/PaymentBaseController.cs

@@ -58,7 +58,9 @@ protected async Task<IActionResult> ProduceActionResultAsync(PaymentOperationSta
 
             PaymentOperationStatus.NotFound => NotFound(),
 
-            PaymentOperationStatus.NotThingToDo => this.RedirectToContentDisplay(paidStatusViewModel.Content),
+            PaymentOperationStatus.NotThingToDo => paidStatusViewModel.Content is { } content
+                ? this.RedirectToContentDisplay(content)
+                : NotFound(),
 
             PaymentOperationStatus.WaitingForRedirect => Redirect(url: paidStatusViewModel.Url),
 

src/Modules/OrchardCore.Commerce.Payment/Services/DummyPaymentProvider.cs

@@ -40,7 +40,7 @@ public DummyPaymentProvider(
         // This provider doesn't have any special data, and it should only be displayed during development even if the
         // feature is enabled. So if the condition is met a blank object is returned, otherwise null which will cause
         // the provider to be skipped when used through the viewModel.WithProviderDataAsync(providers) method.
-        Task.FromResult(_hca.HttpContext.IsDevelopmentAndLocalhost() ? new object() : null);
+        Task.FromResult(_hca.HttpContext?.IsDevelopmentAndLocalhost() == true ? new object() : null);
 
     public async Task<PaymentOperationStatusViewModel> UpdateAndRedirectToFinishedOrderAsync(
         ContentItem order,

src/Modules/OrchardCore.Commerce.Payment/Services/PaymentService.cs

@@ -361,7 +361,7 @@ private async Task<bool> HandleErrorsAsync(IList<string> errors, bool notifyOnEr
     public async Task<IList<string>> UpdateOrderWithDriversAsync(ContentItem order)
     {
         await _contentItemDisplayManager.UpdateEditorAsync(order, _updateModelAccessor.ModelUpdater, isNew: false);
-        return _updateModelAccessor.ModelUpdater.GetModelErrorMessages()?.AsList() ?? Array.Empty<string>();
+        return _updateModelAccessor.ModelUpdater.GetModelErrorMessages().AsList();
     }
 
     public async Task UpdateOrderToOrderedAsync(
@@ -459,7 +459,7 @@ await _paymentProvidersLazy
                 exception,
                 "An exception has occurred during checkout form validation for shopping cart ID {ShoppingCartId}.",
                 shoppingCartIdForDisplay);
-            var errorMessage = _hca.HttpContext.IsDevelopmentAndLocalhost()
+            var errorMessage = _hca.HttpContext?.IsDevelopmentAndLocalhost() == true
                 ? exception.ToString()
                 : H["An exception has occurred during checkout form validation for shopping cart ID {0}.", shoppingCartIdForDisplay].Value;