OCC-314: Remove Node.js dependency (#577)

Author: sarahelsaig

.github/workflows/build-and-test.yml

@@ -31,8 +31,15 @@ jobs:
     name: Codespell
     uses: Lombiq/GitHub-Actions/.github/workflows/codespell.yml@dev
 
+  lint:
+    name: Lint Scripts, Styles, and Texts
+    uses: Lombiq/NodeJs-Extensions/.github/workflows/lint.yml@dev
+    with:
+      scripts: 'src/Modules/OrchardCore.Commerce, src/Modules/OrchardCore.Commerce.ContentFields, src/Modules/OrchardCore.Commerce.Payment.Stripe'
+      styles-css: 'src/Modules/OrchardCore.Commerce, src/Modules/OrchardCore.Commerce.Payment'
+
   post-pull-request-checks-automation:
-    needs: [build-and-test-linux, build-and-test-windows, codespell]
+    needs: [build-and-test-linux, build-and-test-windows, codespell, lint]
     if: github.event.pull_request != ''
     uses: Lombiq/GitHub-Actions/.github/workflows/post-pull-request-checks-automation.yml@dev
     secrets:

.gitignore

@@ -4,7 +4,7 @@
 obj/
 bin/
 artifacts/
-wwwroot/
+is-cache/
 node_modules/
 *.user
 .pnpm-debug.log

Directory.Packages.props

@@ -17,7 +17,6 @@
     <PackageVersion Include="Lombiq.HelpfulLibraries.OrchardCore" Version="$(LombiqHelpfulLibrariesVersion)" />
     <PackageVersion Include="Lombiq.HelpfulLibraries.AspNetCore" Version="$(LombiqHelpfulLibrariesVersion)" />
     <PackageVersion Include="Lombiq.HelpfulLibraries.Refit" Version="$(LombiqHelpfulLibrariesVersion)" />
-    <PackageVersion Include="Lombiq.NodeJs.Extensions" Version="2.1.3" />
     <PackageVersion Include="Lombiq.Tests" Version="4.0.1-alpha.1.osoe-935" />
     <PackageVersion Include="Lombiq.Tests.UI" Version="$(LombiqTestsUIVersion)" />
     <PackageVersion Include="Lombiq.Tests.UI.AppExtensions" Version="$(LombiqTestsUIVersion)" />

Readme.md

@@ -24,19 +24,6 @@ See the [discussions page](https://github.com/OrchardCMS/OrchardCore.Commerce/di
 
 ### Pre-requisites
 
-This project uses [`Lombiq Node.js Extensions`](https://github.com/Lombiq/NodeJs-Extensions) to compile and lint client-side assets. See its pre-requisites [here](https://github.com/Lombiq/NodeJs-Extensions/tree/dev#pre-requisites).
-
-If you want to include OrchardCore.Commerce as a git submodule instead of NuGet package, include the [`Lombiq Helpful Libraries`](https://github.com/Lombiq/Helpful-Libraries/) and `Lombiq Node.js Extensions` submodules as well. In your solution directory create a _Directory.Build.props_ file if one doesn't exist. This should contain the properties that configure the path to the _Lombiq.HelpfulLibraries.OrchardCore.csproj_ file and the _Lombiq.NodeJs.Extensions_ project directory. For example:
-
-```xml
-<Project>
-  <PropertyGroup>
-    <LombiqHelpfulLibrariesPath>$(MSBuildThisFileDirectory)/src/Libraries/Lombiq.HelpfulLibraries</LombiqHelpfulLibrariesPath>
-    <LombiqNodeJsExtensionsPath>$(MSBuildThisFileDirectory)/src/Utilities/Lombiq.NodeJs.Extensions/Lombiq.NodeJs.Extensions</LombiqNodeJsExtensionsPath>
-  </PropertyGroup>
-</Project>
-```
-
 If you have [Lombiq Analyzers](https://github.com/Lombiq/.NET-Analyzers) included in your project as a submodule you should also add the following property to the _Directory.Build.props_ file:
 
 ```xml

docs/resources/libraries/README.md

@@ -14,7 +14,6 @@ The below table lists the different Tests libraries and code analyzers:
 |------------------------------------------------------------------------|--------------------------------------------------------------------------------|----------------------------------------------------------------------------------|
 | [Lombiq.Analyzers](https://github.com/Lombiq/.NET-Analyzers)           | .NET code analyzers and code convention settings                               | [BSD-3-Clause](https://github.com/Lombiq/.NET-Analyzers/blob/dev/License.md)     |
 | [Lombiq.HelpfulLibraries](https://github.com/Lombiq/Helpful-Libraries) | libraries that can be handy when developing for Orchard                        | [BSD-3-Clause](https://github.com/Lombiq/Helpful-Libraries/blob/dev/License.md)  |
-| [Lombiq.NodeJs.Extensions](https://github.com/Lombiq/.NET-Analyzers)   | .NET code analyzers and code convention settings                               | [BSD-3-Clause](https://github.com/Lombiq/NodeJs-Extensions/blob/dev/License.md)  |
 | [Lombiq.Tests.UI](https://github.com/Lombiq/UI-Testing-Toolbox)        | Web UI testing toolbox for Orchard Core applications with Selenium             | [BSD-3-Clause](https://github.com/Lombiq/UI-Testing-Toolbox/blob/dev/License.md) |
 | [VS Test SDK](https://github.com/microsoft/vstest/)                    | Visual Studio Test Platform.                                                   | [MIT](https://github.com/microsoft/vstest/blob/master/LICENSE)                   |
 | [xUnit 3](https://github.com/xunit/xunit)                              | Free, open source, community-focused unit testing tool for the .NET Framework. | [MIT](https://github.com/xunit/xunit/blob/main/LICENSE)                          |

mkdocs.yml

@@ -66,10 +66,6 @@ plugins:
   - search
   - git-authors
   - git-revision-date-localized
-  - exclude:
-      glob:
-        # Excluding the large node folder with all its MD files. We can't exclude everything apart from docs because there are links to e.g. C# files too.
-        - "*node_modules*"
 
 # Page tree
 nav:

renovate.json5

@@ -4,15 +4,4 @@
     addLabels: [
         'no-jira-community-activity-issue',
     ],
-    packageRules: [
-        {
-            // Not updating any of the node.js dependencies as they will be soon removed via
-            // https://github.com/OrchardCMS/OrchardCore.Commerce/issues/527.
-            matchPackageNames: [
-                'eslint*',
-                'pnpm',
-            ],
-            enabled: false,
-        },
-    ],
 }

src/Modules/OrchardCore.Commerce.ContentFields/OrchardCore.Commerce.ContentFields.csproj

@@ -44,15 +44,4 @@
     <PackageReference Include="Lombiq.HelpfulLibraries.OrchardCore" />
   </ItemGroup>
 
-  <ItemGroup Condition="Exists($(LombiqNodeJsExtensionsPath))">
-    <ProjectReference Include="$(LombiqNodeJsExtensionsPath)\Lombiq.NodeJs.Extensions.csproj" />
-  </ItemGroup>
-  <ImportGroup Condition="Exists($(LombiqNodeJsExtensionsPath))">
-    <Import Project="$(LombiqNodeJsExtensionsPath)\Lombiq.NodeJs.Extensions.props" />
-    <Import Project="$(LombiqNodeJsExtensionsPath)\Lombiq.NodeJs.Extensions.targets" />
-  </ImportGroup>
-  <ItemGroup Condition="!Exists($(LombiqNodeJsExtensionsPath))">
-    <PackageReference Include="Lombiq.NodeJs.Extensions" />
-  </ItemGroup>
-
 </Project>

src/Modules/OrchardCore.Commerce.ContentFields/ResourceManagementOptionsConfiguration.cs

@@ -12,9 +12,7 @@ static ResourceManagementOptionsConfiguration() =>
         _manifest
             .DefineScript(CommerceRegions)
             .SetDependencies(JQuery)
-            .SetUrl(
-                "~/OrchardCore.Commerce.ContentFields/js/commerce-regions.min.js",
-                "~/OrchardCore.Commerce.ContentFields/js/commerce-regions.js")
+            .SetUrl("~/OrchardCore.Commerce.ContentFields/js/commerce-regions.js")
             .SetVersion("1.0.0");
 
     public void Configure(ResourceManagementOptions options) => options.ResourceManifests.Add(_manifest);