After payment, need to delete the shopping cart in session and cookies#568
Conversation
…enceBase' that could not be resolved
|
@sarahelsaig please review it |
| /// When deriving a custom implementation, please inherit from <see cref="ShoppingCartPersistenceBase"/> to retain event | ||
| /// When deriving a custom implementation, please inherit from ShoppingCartPersistenceBase to retain event |
There was a problem hiding this comment.
What's the reason of this change?
There was a problem hiding this comment.
You've marked this as resolved without answering the question. Please resolve conversations, that's for the reviewer. (Automatically resolving via "commit suggestion" is fine.)
…ShoppingCartPersistence.cs Co-authored-by: Sára El-Saig <sara.el-saig@lombiq.com>
Co-authored-by: Sára El-Saig <sara.el-saig@lombiq.com>
…chardCore.Commerce into DeleteShoppingCart
| /// When deriving a custom implementation, please inherit from <see cref="ShoppingCartPersistenceBase"/> to retain event | ||
| /// When deriving a custom implementation, please inherit from ShoppingCartPersistenceBase to retain event |
There was a problem hiding this comment.
You've marked this as resolved without answering the question. Please resolve conversations, that's for the reviewer. (Automatically resolving via "commit suggestion" is fine.)
|
@infofromca This is still not addressed: #568 (comment) |
|
Hi @sarahelsaig did you see Because of the separation, other project need to reference this interface. like IShoppingCartHelpers, |
|
@sarahelsaig The most importance is that PaymentService need IShoppingCartPersistence, so move it to Abstraction project, otherwise it will have circle ref. |
I haven't seen any comments from you before this. If they are stuck in "pending", that's because GitHub thinks you are writing a review. You can submit it as a comment like this: |
…ShoppingCartPersistence.cs
2 participants
Fix #543