Skip to content

OCC-356: Move CurrencyCollectionConstants into Stripe project without breaking #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LombiqBot merged 4 commits into from
May 30, 2025
Merged

OCC-356: Move CurrencyCollectionConstants into Stripe project without breaking #592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
97035d6
Move file to the correct project.
sarahelsaig May 30, 2025
3bbc92f
Add ghost file.
sarahelsaig May 30, 2025
1672f2a
Update namespaces.
sarahelsaig May 30, 2025
b4c3dc2
Improve spacing.
sarahelsaig May 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions src/Modules/OrchardCore.Commerce.Payment.Stripe/Constants/CurrencyCollectionConstants.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
using System.Collections.Generic;

namespace OrchardCore.Commerce.Payment.Stripe.Constants;

public static class CurrencyCollectionConstants
{
public static readonly IEnumerable<string> SpecialCases = ["ISK", "HUF", "TWD", "UGX"];

// Note that https://docs.stripe.com/currencies#zero-decimal contains UGX on the list as well, however this is a
// mistake because https://docs.stripe.com/currencies#special-cases explicitly states that UGX is a special case
// (see above) where it's effectively zero-decimal but uses the two-decimal format for backwards compatibility.
public static readonly IEnumerable<string> ZeroDecimalCurrencies =
[
"BIF",
"CLP",
"DJF",
"GNF",
"JPY",
"KMF",
"KRW",
"MGA",
"PYG",
"RWF",
"VND",
"VUV",
"XAF",
"XOF",
"XPF",
];
}
2 changes: 1 addition & 1 deletion src/Modules/OrchardCore.Commerce.Payment.Stripe/Helpers/AmountHelpers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
using OrchardCore.Commerce.MoneyDataType;
using System.Linq;
using static OrchardCore.Commerce.Payment.Constants.CurrencyCollectionConstants;
using static OrchardCore.Commerce.Payment.Stripe.Constants.CurrencyCollectionConstants;

namespace OrchardCore.Commerce.Payment.Stripe.Helpers;

Expand Down
4 changes: 4 additions & 0 deletions src/Modules/OrchardCore.Commerce.Payment/Constants/CurrencyCollectionConstants.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,17 @@
using System;
using System.Collections.Generic;

namespace OrchardCore.Commerce.Payment.Constants;

public static class CurrencyCollectionConstants
{
[Obsolete("This is a Stripe-specific property, use the equivalent in the OrchardCore.Commerce.Payment.Stripe project.")]
public static readonly IEnumerable<string> SpecialCases = ["ISK", "HUF", "TWD", "UGX"];

// Note that https://docs.stripe.com/currencies#zero-decimal contains UGX on the list as well, however this is a
// mistake because https://docs.stripe.com/currencies#special-cases explicitly states that UGX is a special case
// (see above) where it's effectively zero-decimal but uses the two-decimal format for backwards compatibility.
[Obsolete("This is a Stripe-specific property, use the equivalent in the OrchardCore.Commerce.Payment.Stripe project.")]
public static readonly IEnumerable<string> ZeroDecimalCurrencies =
[
"BIF",
Expand Down
Loading