Fix action-bar height and sticky position for list search#19330
Merged
Conversation
sebastienros
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes improvements to the admin list search panel and enhances the maintainability of the action bar's styling by replacing hardcoded values with CSS variables. The main changes involve restructuring the form markup for better HTML semantics and updating the action bar's positioning to use a variable for easier theme customization.
Admin list search panel markup:
<form>tag inside the.cardelement inListPartDetailAdminSearchPanel.cshtmlto improve semantic structure and avoid wrapping the entire card in a form. [1] [2]Styling and maintainability:
.action-barCSS in both the SCSS source (_action-bar.scss) and compiled CSS (TheAdmin.css) to use the--oc-top-nav-heightCSS variable instead of a hardcodedtopvalue, making it easier to adjust the top navigation height across themes. [1] [2]