Consider extracting Liquid strings from JSON files

[sarahelsaig]

The tool supports extracting strings from Liquid files. But it does not extract Liquid strings from *.recipe.json files. For example the Lombiq Training Demo repo contains a recipe with the "You have no permission to manage Person Page content items." text:

git clone https://github.com/Lombiq/Orchard-Training-Demo-Module.git
cd Orchard-Training-Demo-Module/
extractpo . . -t Liquid
grep "You have no permission" Lombiq.TrainingDemo.pot

It says Lombiq.TrainingDemo: Found 55 strings., but the expected string is not found among them.

Note

If this is considered dynamic content and intentionally not supported, that's fine too. But in this case a note should be added to the Readme for clarity.

[hishamco]

PO Extractor extracts localization strings from liquid files, not JSON files. If this used in OC we could subclass LiquidStringExtractor to make this happen

[sarahelsaig]

At least in Lombiq projects Liquid in recipes is much more common than Liquid files. Especially for widgets and in the DotNest tenants that we maintain. If you are open to it, I may implement a subclass for LiquidStringExtractor some time soon.

[hishamco]

If you are open to it,

This is not my project, a community project. Feel free to add what it might help the community

[hishamco]

@sarahelsaig, are you willing to implement this?