Fixed an issue where credential helper values would be incorrectly quoted in Git config

DaRosenberg · DaRosenberg · commit dcb72da90eb0 · 2022-03-04T19:14:15.000+01:00
diff --git a/dist/main.js b/dist/main.js
@@ -15105,22 +15105,22 @@ exports.configureGitAuthentication = configureGitAuthentication;
 function setCommitterName(committerName) {
     return __awaiter(this, void 0, void 0, function* () {
         core.debug(`Setting Git committer name globally as '${committerName}'...`);
-        yield execGit("config", "--global", "user.name", `"${committerName}"`);
+        yield execGit("config", "--global", "user.name", committerName);
         core.debug("Git committer name was set successfully.");
     });
 }
 exports.setCommitterName = setCommitterName;
 function setCommitterEmail(committerEmail) {
     return __awaiter(this, void 0, void 0, function* () {
         core.debug(`Setting Git committer email globally as '${committerEmail}'...`);
-        yield execGit("config", "--global", "user.email", `"${committerEmail}"`);
+        yield execGit("config", "--global", "user.email", committerEmail);
         core.debug("Git committer email was set successfully.");
     });
 }
 exports.setCommitterEmail = setCommitterEmail;
 function addCredentialHelper(credentialHelper) {
     return __awaiter(this, void 0, void 0, function* () {
-        yield execGit("config", "--global", "--add", "credential.helper", `"${credentialHelper}"`);
+        yield execGit("config", "--global", "--add", "credential.helper", credentialHelper);
     });
 }
 function execGit(commandName, ...args) {
diff --git a/lib/git.ts b/lib/git.ts
@@ -27,7 +27,7 @@ export async function setCommitterName(committerName: string)
 {
 	core.debug(`Setting Git committer name globally as '${committerName}'...`);
 
-	await execGit("config", "--global", "user.name", `"${committerName}"`);
+	await execGit("config", "--global", "user.name", committerName);
 
 	core.debug("Git committer name was set successfully.");
 }
@@ -36,14 +36,14 @@ export async function setCommitterEmail(committerEmail: string)
 {
 	core.debug(`Setting Git committer email globally as '${committerEmail}'...`);
 
-	await execGit("config", "--global", "user.email", `"${committerEmail}"`);
+	await execGit("config", "--global", "user.email", committerEmail);
 
 	core.debug("Git committer email was set successfully.");
 }
 
 async function addCredentialHelper(credentialHelper: string)
 {
-	await execGit("config", "--global", "--add", "credential.helper", `"${credentialHelper}"`);
+	await execGit("config", "--global", "--add", "credential.helper", credentialHelper);
 }
 
 async function execGit(commandName: string, ...args: string[])

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ export async function setCommitterName(committerName: string)`
`27`	`27`	`{`
`28`	`28`	core.debug(`Setting Git committer name globally as '${committerName}'...`);
`29`	`29`
`30`		- await execGit("config", "--global", "user.name", `"${committerName}"`);
	`30`	`+ await execGit("config", "--global", "user.name", committerName);`
`31`	`31`
`32`	`32`	`core.debug("Git committer name was set successfully.");`
`33`	`33`	`}`
`@@ -36,14 +36,14 @@ export async function setCommitterEmail(committerEmail: string)`
`36`	`36`	`{`
`37`	`37`	core.debug(`Setting Git committer email globally as '${committerEmail}'...`);
`38`	`38`
`39`		- await execGit("config", "--global", "user.email", `"${committerEmail}"`);
	`39`	`+ await execGit("config", "--global", "user.email", committerEmail);`
`40`	`40`
`41`	`41`	`core.debug("Git committer email was set successfully.");`
`42`	`42`	`}`
`43`	`43`
`44`	`44`	`async function addCredentialHelper(credentialHelper: string)`
`45`	`45`	`{`
`46`		- await execGit("config", "--global", "--add", "credential.helper", `"${credentialHelper}"`);
	`46`	`+ await execGit("config", "--global", "--add", "credential.helper", credentialHelper);`
`47`	`47`	`}`
`48`	`48`
`49`	`49`	`async function execGit(commandName: string, ...args: string[])`