Create Pool booster central registry and Merkl pool booster on Mainnet - #2676
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2676 +/- ##
==========================================
- Coverage 38.28% 35.82% -2.46%
==========================================
Files 112 112
Lines 5331 5331
Branches 1412 1412
==========================================
- Hits 2041 1910 -131
- Misses 3289 3420 +131
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| "PoolBoosterFactoryMerkl", | ||
| [ | ||
| oeth.address, | ||
| addresses.mainnet.Timelock, |
There was a problem hiding this comment.
I think it could be nice to set the strategist here instead of the Timelock, because if for any reason the bribe creation fail, you will have to wait 5 days to create a new one.
| await withConfirmation( | ||
| cPoolBoostCentralRegistryProxy | ||
| .connect(sDeployer)["initialize(address,address,bytes)"]( | ||
| dPoolBoostCentralRegistry.address, |
There was a problem hiding this comment.
I think we should start the strategist as governor and change it later, when we are ready
There was a problem hiding this comment.
This is only to approve and remove factories. Is there any benefit to going initially with the strategist?
clement-ux
left a comment
clement-ux
left a comment
There was a problem hiding this comment.
Good idea to rename oSonic to oToken!
Looks good to me 👍
3 participants
Code Change Checklist
To be completed before internal review begins: