test: optimize and add coverage job to ./yml flow#412
Merged
Conversation
radomir-sebek
marked this pull request as ready for review
June 20, 2025 08:26
Contributor
|
Thanks @radomir-sebek, nice work. Merging this PR now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notable changes:
hardhat.node.config.ts, there was a strange logic for setting parameter of solidity compiler calledviaIR. Namely, if this value is false, then upon runningnpm run coveragewill throw compile errorthat seems to goes deep into argotorg/solidity#3446, which is beyond my knowledge.
After noticing that in
compiler_config.jsonthis parameter is set totrue, I decided to update this flag in scope of coverage reporting as well.Basically, I couldn't find better way to get coverage to work (tried updating solidity-coverage hw did not helped), and setting
viaIR to trueseemed like legit option.SOLIDITY_COVERAGE=true
This was recommended based on here
final html report should look like this: