Skip to content

Added pagination#4

Open
zacoppotamus wants to merge 1 commit into
Ossus:masterfrom
zacoppotamus:master
Open

Added pagination#4
zacoppotamus wants to merge 1 commit into
Ossus:masterfrom
zacoppotamus:master

Conversation

@zacoppotamus
Copy link
Copy Markdown

No description provided.

@p2
Copy link
Copy Markdown
Member

p2 commented Sep 9, 2017

Hey, thanks for this. While it works it's a rather hacky solution. Things I would change:

  • create a _get_url() method that is used by _get() so you don't have to manipulate next_page and can use as-is
  • create a sub-method of the parsing in _sales() so that it can be called recursively
  • remove the whitespace fixes in your diff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants