Skip to content

Commit d9aa007

Browse files
committed
chore: 코드리뷰 반영 #74
1 parent fdf33a8 commit d9aa007

4 files changed

Lines changed: 15 additions & 3 deletions

File tree

.github/workflows/android-ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,5 +43,5 @@ jobs: # CI에서 수행할 작업을 정의한다.
4343
# ./gradlew detekt
4444

4545
- name: Run build
46-
run: ./gradlew buildDebug --stacktrace
46+
run: ./gradlew assembleDebug --stacktrace
4747

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -169,3 +169,4 @@ fabric.properties
169169

170170
!/gradle/wrapper/gradle-wrapper.jar
171171
/app/debug/output-metadata.json
172+
/app/build/outputs/**/output-metadata.json

app/build.gradle.kts

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,15 @@ android {
3434
}
3535

3636
signingConfigs {
37+
val debugKeystore = rootProject.file("debug.keystore")
38+
if (debugKeystore.exists()) {
39+
getByName("debug") {
40+
storeFile = debugKeystore
41+
storePassword = "android"
42+
keyAlias = "androiddebugkey"
43+
keyPassword = "android"
44+
}
45+
}
3746
getByName("debug") {
3847
storeFile = file("$rootDir/debug.keystore")
3948
storePassword = "android"
@@ -108,7 +117,7 @@ dependencies {
108117
// Kakao SDK
109118
implementation("com.kakao.sdk:v2-all:2.20.6")
110119
implementation("com.kakao.sdk:v2-user:2.20.6") // 카카오 로그인 API 모듈
111-
implementation ("com.kakao.maps.open:android:2.12.8") // 카카오 맵 API
120+
implementation("com.kakao.maps.open:android:2.12.8") // 카카오 맵 API
112121

113122
// coil
114123
implementation(libs.coil.compose)

gradle/libs.versions.toml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ retrofitKotlinSerializationConverter = "1.0.0"
2525
datastorePreferences = "1.1.3"
2626
playServicesLocation = "21.3.0"
2727
firebaseCrashlytics = "3.0.6"
28+
googleServices = "4.4.3"
2829

2930
[libraries]
3031
androidx-core-ktx = { group = "androidx.core", name = "core-ktx", version.ref = "coreKtx" }
@@ -71,4 +72,5 @@ kotlin-serialization = { id = "org.jetbrains.kotlin.plugin.serialization", versi
7172
kotlin-android = { id = "org.jetbrains.kotlin.android", version.ref = "kotlin" }
7273
kotlin-compose = { id = "org.jetbrains.kotlin.plugin.compose", version.ref = "kotlin" }
7374
dagger-hilt = { id = "com.google.dagger.hilt.android", version.ref = "hiltAndroid" }
74-
firebase-crashlytics = { id = "com.google.firebase.crashlytics", version.ref = "firebaseCrashlytics" }
75+
firebase-crashlytics = { id = "com.google.firebase.crashlytics", version.ref = "firebaseCrashlytics" }
76+
google-services = { id = "com.google.gms.google-services", version.ref = "googleServices" }

0 commit comments

Comments
 (0)