RMET-4216 ::: adding allowsBackForwardNavigationGestures for WKWebView on iOS#21
Conversation
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
OS-ruimoreiramendes
requested review from
ItsChaceD,
OS-pedrogustavobilro,
alexgerardojacinto,
andredestro and
eric-horodyski
and removed request for
a team
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) ✅ code/snyk check is complete. No issues have been found. (View Details) |
|
| animationEffect: OSIABAnimationEffect = .defaultValue, | ||
| customUserAgent: String? = nil | ||
| customUserAgent: String? = nil, | ||
| allowsBackForwardNavigationGestures: Bool = true, |
There was a problem hiding this comment.
The default value of the WKWebView's allowsBackForwardNavigationGestures property is false. Would it make sense to change this default value?
There was a problem hiding this comment.
I actually discussed this with Alexandre, and he suggested that enabling allowsBackForwardNavigationGestures by default makes more sense, as it improves the navigation experience in most use cases.
| The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | ||
| and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | ||
|
|
||
| ## 2.0.1 |
There was a problem hiding this comment.
We usually update the version number only at the time of release, keeping 'Unreleased' until then. I think this helps avoid confusion about whether a feature has been released or not.
There was a problem hiding this comment.
I updated with the upcoming version instead of “Unreleased”, since this is the only pending feature and we’re planning to release it next week. I had already validated this with Alexandre, and he suggested going ahead with the version update now.
6 participants
Description
Added support for back and forward swipe navigation gestures in WKWebView via the allowsBackForwardNavigationGestures option.
Context
References: https://outsystemsrd.atlassian.net/browse/RMET-4216
Type of changes
Tests
Tested locally on iOS using Xcode and a physical device. Verified that back and forward swipe gestures work as expected when
allowsBackForwardNavigationGesturesis set to true.Screenshots (if appropriate)
Checklist
RNMT-XXXX <title>