Skip to content

Commit 1e83aab

Browse files
fix: Remove manifestPlaceholders from SDK (#22)
* chore: Remove manifestPlaceholders from SDK * chore: Prepare for next release
1 parent 937b1c8 commit 1e83aab

2 files changed

Lines changed: 1 addition & 8 deletions

File tree

OneSignalSDK/onesignal/build.gradle

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,6 @@ android {
33
compileSdk 34
44
namespace "com.onesignal"
55
defaultConfig {
6-
// Normally we shouldn't need to redefine manifestPlaceholders for our onesignal project
7-
// but Android Studio gets a sync error if these are not here.
8-
// - /gradlew onesignal:assembleRelease is fine from the console.
9-
// We can't use static values are these are directly added to the AndroidManifest.xml in the .aar file.
10-
manifestPlaceholders = [onesignal_app_id: '${onesignal_app_id}',
11-
// Project number pulled from dashboard, local value is ignored
12-
onesignal_google_project_number: '${onesignal_google_project_number}']
136
minSdkVersion 26
147
targetSdk 34
158
consumerProguardFiles 'consumer-proguard-rules.pro'

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,5 +7,5 @@
77
<modelVersion>4.0.0</modelVersion>
88
<groupId>com.github.outsystems</groupId>
99
<artifactId>onesignal-android-sdk</artifactId>
10-
<version>3.15.5-OS5</version>
10+
<version>3.15.5-OS6</version>
1111
</project>

0 commit comments

Comments
 (0)