Merge pull request #154 from OutSystems/RDODCP-236-RDODCP-229

RDODCP-236-RDODCP-229: Warn deprecation of --hostname and go version bump updates

Author: samartha-pm

README.md

@@ -200,9 +200,6 @@ If your organization uses a centralized log management product, see its document
         --header, Set a custom header in the form "HeaderName: HeaderContent". 
         Use the Token displayed on ODC Portal in using token as HeaderName.
         
-        --hostname, Optionally set the 'Host' header (defaults to the host
-        found in the server url).
-
         --pid Generate pid file in current working directory
 
         -v, Enable verbose logging

go.mod

@@ -12,12 +12,12 @@ require (
 	github.com/gorilla/websocket v1.5.3 // indirect
 	github.com/jpillora/backoff v1.0.0 // indirect
 	github.com/jpillora/sizestr v1.0.0 // indirect
-	golang.org/x/crypto v0.40.0 // indirect
-	golang.org/x/net v0.42.0 // indirect
+	golang.org/x/crypto v0.41.0 // indirect
+	golang.org/x/net v0.43.0 // indirect
 	golang.org/x/sync v0.16.0 // indirect
-	golang.org/x/sys v0.34.0 // indirect
+	golang.org/x/sys v0.35.0 // indirect
 )
 
-replace github.com/jpillora/chisel => github.com/outsystems/chisel v1.10.1-os.6
+replace github.com/jpillora/chisel => github.com/outsystems/chisel v1.10.1-os.8
 
-go 1.23.8
+go 1.24.6

go.sum

@@ -16,17 +16,17 @@ github.com/jpillora/sizestr v1.0.0 h1:4tr0FLxs1Mtq3TnsLDV+GYUWG7Q26a6s+tV5Zfw2yg
 github.com/jpillora/sizestr v1.0.0/go.mod h1:bUhLv4ctkknatr6gR42qPxirmd5+ds1u7mzD+MZ33f0=
 github.com/maxatome/go-testdeep v1.14.0 h1:rRlLv1+kI8eOI3OaBXZwb3O7xY3exRzdW5QyX48g9wI=
 github.com/maxatome/go-testdeep v1.14.0/go.mod h1:lPZc/HAcJMP92l7yI6TRz1aZN5URwUBUAfUNvrclaNM=
-github.com/outsystems/chisel v1.10.1-os.6 h1:1hLD63xTL9tlC8RNrp4SkII/ICd1cw1npOC18Im3Hsk=
-github.com/outsystems/chisel v1.10.1-os.6/go.mod h1:s8pC08aT0NDYXFNWaid5t1/SQGbqsT3FMgvU/ZS1U2E=
-golang.org/x/crypto v0.40.0 h1:r4x+VvoG5Fm+eJcxMaY8CQM7Lb0l1lsmjGBQ6s8BfKM=
-golang.org/x/crypto v0.40.0/go.mod h1:Qr1vMER5WyS2dfPHAlsOj01wgLbsyWtFn/aY+5+ZdxY=
-golang.org/x/net v0.42.0 h1:jzkYrhi3YQWD6MLBJcsklgQsoAcw89EcZbJw8Z614hs=
-golang.org/x/net v0.42.0/go.mod h1:FF1RA5d3u7nAYA4z2TkclSCKh68eSXtiFwcWQpPXdt8=
+github.com/outsystems/chisel v1.10.1-os.8 h1:49AGDE3ZIdBoBsKx2rHBZLwj5Tslpw3awfupsZr3zPo=
+github.com/outsystems/chisel v1.10.1-os.8/go.mod h1:LGo6iEF93bXsh81iLbM6sdHSX93JPIgr0XXvHR2ApLE=
+golang.org/x/crypto v0.41.0 h1:WKYxWedPGCTVVl5+WHSSrOBT0O8lx32+zxmHxijgXp4=
+golang.org/x/crypto v0.41.0/go.mod h1:pO5AFd7FA68rFak7rOAGVuygIISepHftHnr8dr6+sUc=
+golang.org/x/net v0.43.0 h1:lat02VYK2j4aLzMzecihNvTlJNQUq316m2Mr9rnM6YE=
+golang.org/x/net v0.43.0/go.mod h1:vhO1fvI4dGsIjh73sWfUVjj3N7CA9WkKJNQm2svM6Jg=
 golang.org/x/sync v0.16.0 h1:ycBJEhp9p4vXvUZNszeOq0kGTPghopOL8q0fq3vstxw=
 golang.org/x/sync v0.16.0/go.mod h1:1dzgHSNfp02xaA81J2MS99Qcpr2w7fw1gpm99rleRqA=
-golang.org/x/sys v0.34.0 h1:H5Y5sJ2L2JRdyv7ROF1he/lPdvFsd0mJHFw2ThKHxLA=
-golang.org/x/sys v0.34.0/go.mod h1:BJP2sWEmIv4KK5OTEluFJCKSidICx8ciO85XgH3Ak8k=
-golang.org/x/term v0.33.0 h1:NuFncQrRcaRvVmgRkvM3j/F00gWIAlcmlB8ACEKmGIg=
-golang.org/x/term v0.33.0/go.mod h1:s18+ql9tYWp1IfpV9DmCtQDDSRBUjKaw9M1eAv5UeF0=
+golang.org/x/sys v0.35.0 h1:vz1N37gP5bs89s7He8XuIYXpyY0+QlsKmzipCbUtyxI=
+golang.org/x/sys v0.35.0/go.mod h1:BJP2sWEmIv4KK5OTEluFJCKSidICx8ciO85XgH3Ak8k=
+golang.org/x/term v0.34.0 h1:O/2T7POpk0ZZ7MAzMeWFSg6S5IpWd/RXDlM9hgM3DR4=
+golang.org/x/term v0.34.0/go.mod h1:5jC53AEywhIVebHgPVeg0mj8OD3VO9OzclacVrqpaAw=
 golang.org/x/time v0.6.0 h1:eTDhh4ZXt5Qf0augr54TN6suAUudPcawVZeIAPU7D4U=
 golang.org/x/time v0.6.0/go.mod h1:3BpzKBy/shNhVucY/MWOyx10tF3SFh9QdLuxbVysPQM=

main.go

@@ -104,9 +104,6 @@ var clientHelp = `
     --header, Set a custom header in the form "HeaderName: HeaderContent". 
 	Use the Token displayed on ODC Portal in using token as HeaderName.
 
-    --hostname, Optionally set the 'Host' header (defaults to the host
-    found in the server url).
-
 	--pid Generate pid file in current working directory
 
     -v, Enable verbose logging
@@ -130,7 +127,7 @@ func client(args []string) {
 	flags.DurationVar(&config.MaxRetryInterval, "max-retry-interval", 0, "")
 	flags.StringVar(&config.Proxy, "proxy", "", "")
 	flags.Var(&headerFlags{config.Headers}, "header", "")
-	hostname := flags.String("hostname", "", "")
+	hostname := flags.String("hostname", "", "Deprecated, will be ignored")
 	pid := flags.Bool("pid", false, "")
 	verbose := flags.Bool("v", false, "")
 	flags.Usage = func() {
@@ -169,7 +166,8 @@ func client(args []string) {
 	}
 	//move hostname onto headers
 	if *hostname != "" {
-		config.Headers.Set("Host", *hostname)
+		log.Printf("[WARN] The --hostname flag will be removed in a future release. Please consider removing it to avoid breaking changes.\n" +
+			"Please specify the correct server URL directly instead.\n")
 	}
 	//ready
 	c, err := chclient.NewClient(&config)