Drop SetDoNotParseResponse in fetchURL -- connection leak#184
Open
mclaughlin-thomas wants to merge 1 commit intoOutSystems:mainfrom
Open
Drop SetDoNotParseResponse in fetchURL -- connection leak#184mclaughlin-thomas wants to merge 1 commit intoOutSystems:mainfrom
mclaughlin-thomas wants to merge 1 commit intoOutSystems:mainfrom
Conversation
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. Pull Request Developer GuidanceQuestions? See the Wiz FAQ. Please contact the Security Office if you encounter issues with Wiz pull request scanning. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function
fetchURL()only reads the response status and Location header -- it does not touch the body.SetDoNotParseResponse(true)tells resty not to drain or close the body for us, transferring that responsibility to the caller.Since we never close it, the body and its underlying socket stay open.
Removing the option lets resty handle body cleanup on its normal path.
No behavior change for callers; existing tests still pass.
If
SetDoNotParseResponseis needed, that close can be added explicitly instead: