Skip to content

RDMR-1284 add EdgeToEdgeGlyphTheme preference to SystemBarPlugin #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
benmccarty91 wants to merge 1 commit into from
Closed

RDMR-1284 add EdgeToEdgeGlyphTheme preference to SystemBarPlugin #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion framework/src/org/apache/cordova/SystemBarPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,13 +50,15 @@ public class SystemBarPlugin extends CordovaPlugin {
private int overrideStatusBarBackgroundColor = INVALID_COLOR;

private boolean canEdgeToEdge = false;
private String edgeToEdgeGlyphTheme = null;

@Override
protected void pluginInitialize() {
context = cordova.getContext();
resources = context.getResources();
canEdgeToEdge = preferences.getBoolean("AndroidEdgeToEdge", false)
&& Build.VERSION.SDK_INT >= Build.VERSION_CODES.VANILLA_ICE_CREAM;
edgeToEdgeGlyphTheme = preferences.getString("EdgeToEdgeGlyphTheme", null);
}

@Override
Expand Down Expand Up @@ -238,7 +240,10 @@ private void updateStatusBar(int bgColor) {

// Automatically set the font and icon color of the system bars based on background color.
boolean isStatusBarBackgroundColorLight;
if(bgColor == Color.TRANSPARENT) {
if (canEdgeToEdge && edgeToEdgeGlyphTheme != null
&& edgeToEdgeGlyphTheme.matches("(?i)(dark|light)")) {
isStatusBarBackgroundColorLight = edgeToEdgeGlyphTheme.equalsIgnoreCase("dark");
} else if(bgColor == Color.TRANSPARENT) {
isStatusBarBackgroundColorLight = isColorLight(getUiModeColor());
} else {
isStatusBarBackgroundColorLight = isColorLight(bgColor);
Expand Down
Loading