Skip to content

feat(android): enable edge-to-edge support for Android 9 and above#35

Closed
OS-kepatotorica wants to merge 1 commit into
masterfrom
feature/RDMR-1275-Android-9-up-Edge-to-Edge
Closed

feat(android): enable edge-to-edge support for Android 9 and above#35
OS-kepatotorica wants to merge 1 commit into
masterfrom
feature/RDMR-1275-Android-9-up-Edge-to-Edge

Conversation

@OS-kepatotorica
Copy link
Copy Markdown

The goal here is to add back an approximation of the old preference StatusBarOverlaysWebview. We did this by removing the API 35, android 15, version gate on the AndroidEdgeToEdge preference, allowing edge-to-edge mode to be enabled on Android 9+ (API 28). We can do this now because AndroidEdgeToEdge is still opt in, so we can enforce an OutSystemsUI upgrade on users who choose to opt in. We couldn't do this before when it was originally going to be the default to be opted in, as that would force a breaking change on users.

Platforms affected

Android

Motivation and Context

This change was added in because we previously made the decision to remove statusBarOverlaysWebview. It turns out our customers did not want that, so we are adding in a feature to get similar functionality back.

Description

At the top

Testing

I used the local version in an app, along with an updated insets injector, here are the results ->
https://outsystemsrd.atlassian.net/wiki/spaces/RDMBLVS/pages/6156877852/Edge+To+Edge+with+StatusBarOverlaysWebview+functionality+Added+Back+In

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary -> Not yet, but it is in the ac, and will be done before anything is released. So I am going to mark the check as a "will be done" instead of an "is done"

The goal here is to add back an approximation of the old preference StatusBarOverlaysWebview. We did this by removing the API 35, android 15, version gate on the AndroidEdgeToEdge preference, allowing edge-to-edge mode to be enabled on Android 9+ (API 28). We can do this now because AndroidEdgeToEdge is still opt in, so we can enforce an OutSystemsUI upgrade on users who choose to opt in. We couldn't do this before when it was originally going to be the default to be opted in, as that would force a breaking change on users.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant