Merge pull request #128 from OutSystems/rc1.6.4

Merge release 1.6.4

Author: gnbm

.vscode/settings.json

@@ -1,13 +1,14 @@
 {
-	"5diffEditor.ignoreTrimWhitespace": true,
+	"diffEditor.ignoreTrimWhitespace": true,
 	"files.autoSave": "off",
 	"editor.minimap.maxColumn": 170,
 	"editor.wordWrapColumn": 170,
-	"editor.formatOnSave": false,
+	"editor.formatOnSave": true,
 	"editor.codeActionsOnSave": {
 		"source.fixAll.eslint": true
 	},
 	"css.lint.fontFaceProperties": "ignore",
+	"scss.lint.fontFaceProperties": "ignore",
 	"editor.defaultFormatter": "esbenp.prettier-vscode",
 	"[html]": {
 		"editor.defaultFormatter": "vscode.html-language-features"
@@ -21,7 +22,10 @@
 	"[json]": {
 		"editor.defaultFormatter": "vscode.json-language-features"
 	},
+	"[scss]": {
+		"editor.defaultFormatter": "esbenp.prettier-vscode"
+	},
 	"[jsonc]": {
 		"editor.defaultFormatter": "vscode.json-language-features"
 	}
-}
+}

CODEOWNERS

@@ -1 +1 @@
-@gnbm @joselrio @BenOsodrac @bmarcelino-fe @rugoncalves @JoaoFerreira-FrontEnd @OS-giulianasilva
+* @gnbm @joselrio @BenOsodrac @bmarcelino-fe @rugoncalves @JoaoFerreira-FrontEnd @OS-giulianasilva

jobs/azure-pipelines-reactive.yml

@@ -18,9 +18,9 @@ stages:
       - bash: |
             declare BRANCH 
             BRANCH=$(system.pullRequest.sourceBranch)
-            echo "Map_Regressions_${BRANCH//[-]/}"
-            echo "##vso[task.setvariable variable=branch;]Map_Regressions_${BRANCH//[-]/}"
-            echo "##vso[task.setvariable variable=module;isoutput=true]Map_Regressions_${BRANCH//[-]/}"
+            echo "Maps_Automation_${BRANCH//[-]/}"
+            echo "##vso[task.setvariable variable=branch;]Maps_Automation_${BRANCH//[-]/}"
+            echo "##vso[task.setvariable variable=module;isoutput=true]Maps_Automation_${BRANCH//[-]/}"
         name: branch_name
 
       #Ping sample test page

package.json

@@ -1,6 +1,6 @@
 {
   "name": "outsystems-maps",
-  "version": "1.6.3",
+  "version": "1.6.4",
   "description": "Outsystems Maps",
   "license": "Apache v2.0",
   "scripts": {

src/OSFramework/Maps/Constants.ts

@@ -1,5 +1,6 @@
 // eslint-disable-next-line @typescript-eslint/no-unused-vars
 namespace OSFramework.Maps.Constants {
     /* OutSystems Maps Version */
-    export const OSMapsVersion = '1.6.3';
+    export const OSMapsVersion = '1.6.4';
+
 }

src/Providers/Maps/Google/Marker/Marker.ts

@@ -82,7 +82,6 @@ namespace Provider.Maps.Google.Marker {
                     OSFramework.Maps.Enum.ErrorCodes.LIB_FailedGeocodingMarker,
                     `Location of the Marker can't be empty.`
                 );
-                return;
             } else {
                 // Let's return a promise that will be resolved or rejected according to the result
                 return new Promise((resolve, reject) => {
@@ -201,6 +200,9 @@ namespace Provider.Maps.Google.Marker {
                             map: this.map.provider
                         });
 
+                        // Call this method so icon respects the sizes that are on config
+                        this._setIconSize();
+
                         // We can only set the events on the provider after its creation
                         this._setMarkerEvents();
 
@@ -255,14 +257,12 @@ namespace Provider.Maps.Google.Marker {
                     case OSFramework.Maps.Enum.OS_Config_Marker.allowDrag:
                         return this._provider.setDraggable(value);
                     case OSFramework.Maps.Enum.OS_Config_Marker.iconHeight:
+                    case OSFramework.Maps.Enum.OS_Config_Marker.iconWidth:
                         this._setIconSize();
                         return;
                     case OSFramework.Maps.Enum.OS_Config_Marker.iconUrl:
                         this._setIcon(value);
                         return;
-                    case OSFramework.Maps.Enum.OS_Config_Marker.iconWidth:
-                        this._setIconSize();
-                        return;
                     case OSFramework.Maps.Enum.OS_Config_Marker.label:
                         return this._provider.setLabel(value);
                     case OSFramework.Maps.Enum.OS_Config_Marker.title: