ROU-12717: Fix name of added event to marker pop-up#258
Merged
rugoncalves merged 4 commits intodevfrom Apr 27, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Google Advanced Marker popup behavior to listen to the correct provider click event (gmp-click) via the existing constants enum, and attempts to harden popup content refresh to avoid runtime errors.
Changes:
- Switched marker popup click listener from a hard-coded
'click'string toConstants.Marker.ProviderEventNames.click(maps togmp-click). - Initialized
_contentStringwith a default empty string. - Updated
refreshPopupContent()to use optional chaining / fallback when reading popup DOM content.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
joselrio
approved these changes
Apr 24, 2026
Contributor
|
@rugoncalves Is it supposed to have failing tests still? |
JoaoFerreira-FrontEnd
approved these changes
Apr 27, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This PR is for simply attaching to the correct event in the case of the Google Advanced Marker. For the new version of the markers, the click event is
gmp-clickand notclick.What was happening
What was done
Test Steps
Checklist