From a0896e4d5c40153680ff53f53a7d6f288f1952e9 Mon Sep 17 00:00:00 2001 From: rug Date: Mon, 20 Apr 2026 13:06:43 +0200 Subject: [PATCH 1/2] Using correct click event --- src/Providers/Maps/Google/Marker/MarkerPopup.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Providers/Maps/Google/Marker/MarkerPopup.ts b/src/Providers/Maps/Google/Marker/MarkerPopup.ts index 3268e981..a3307ff4 100644 --- a/src/Providers/Maps/Google/Marker/MarkerPopup.ts +++ b/src/Providers/Maps/Google/Marker/MarkerPopup.ts @@ -12,7 +12,7 @@ namespace Provider.Maps.Google.Marker { // Open the popup when the user clicks on the Marker // To close the Marker click on it and then use the ESC or the "x" on the top right corner of the popup // Or use the API method - closePopup() - this._provider.addListener('click', () => { + this._provider.addListener(Constants.Marker.ProviderEventNames.click, () => { this.refreshPopupContent(); this.openPopup(); }); From e32f6b688f06e036850acbaaa163b155b4f05cdd Mon Sep 17 00:00:00 2001 From: rug Date: Mon, 20 Apr 2026 13:06:59 +0200 Subject: [PATCH 2/2] Protecting the code --- src/Providers/Maps/Google/Marker/MarkerPopup.ts | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/Providers/Maps/Google/Marker/MarkerPopup.ts b/src/Providers/Maps/Google/Marker/MarkerPopup.ts index a3307ff4..13ed4387 100644 --- a/src/Providers/Maps/Google/Marker/MarkerPopup.ts +++ b/src/Providers/Maps/Google/Marker/MarkerPopup.ts @@ -4,7 +4,7 @@ // eslint-disable-next-line @typescript-eslint/no-unused-vars namespace Provider.Maps.Google.Marker { export class MarkerPopup extends Marker implements OSFramework.Maps.Marker.IMarkerPopup { - private _contentString: string; + private _contentString: string = ''; protected _setMarkerEvents(): void { super._setMarkerEvents(); @@ -36,9 +36,10 @@ namespace Provider.Maps.Google.Marker { } public refreshPopupContent(): void { - this._contentString = OSFramework.Maps.Helper.GetElementByUniqueId(this.uniqueId).querySelector( - OSFramework.Maps.Helper.Constants.markerPopup - ).innerHTML; + this._contentString = + OSFramework.Maps.Helper.GetElementByUniqueId(this.uniqueId)?.querySelector( + OSFramework.Maps.Helper.Constants.markerPopup + )?.innerHTML ?? ''; this.map.features.infoWindow.setPopupContent(this._contentString); } }