Skip to content

ROU-12717: Fix name of added event to marker pop-up #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rugoncalves merged 4 commits into from
Apr 27, 2026
Merged

ROU-12717: Fix name of added event to marker pop-up #258

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a0896e4
Using correct click event
rugoncalves Apr 20, 2026
e32f6b6
Protecting the code
rugoncalves Apr 20, 2026
59e47d5
Merge branch 'dev' into ROU-12717
rugoncalves Apr 22, 2026
3f70b2b
Merge branch 'dev' into ROU-12717
rugoncalves Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/Providers/Maps/Google/Marker/MarkerPopup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,15 @@
// eslint-disable-next-line @typescript-eslint/no-unused-vars
namespace Provider.Maps.Google.Marker {
export class MarkerPopup extends Marker implements OSFramework.Maps.Marker.IMarkerPopup {
private _contentString: string;
private _contentString: string = '';

protected _setMarkerEvents(): void {
super._setMarkerEvents();

// Open the popup when the user clicks on the Marker
// To close the Marker click on it and then use the ESC or the "x" on the top right corner of the popup
// Or use the API method - closePopup()
this._provider.addListener('click', () => {
this._provider.addListener(Constants.Marker.ProviderEventNames.click, () => {
this.refreshPopupContent();
Comment thread
rugoncalves marked this conversation as resolved.
this.openPopup();
});
Comment thread
rugoncalves marked this conversation as resolved.
Expand All @@ -36,9 +36,10 @@ namespace Provider.Maps.Google.Marker {
}

public refreshPopupContent(): void {
this._contentString = OSFramework.Maps.Helper.GetElementByUniqueId(this.uniqueId).querySelector(
OSFramework.Maps.Helper.Constants.markerPopup
).innerHTML;
this._contentString =
OSFramework.Maps.Helper.GetElementByUniqueId(this.uniqueId)?.querySelector(
Comment thread
rugoncalves marked this conversation as resolved.
OSFramework.Maps.Helper.Constants.markerPopup
)?.innerHTML ?? '';
this.map.features.infoWindow.setPopupContent(this._contentString);
}
}
Expand Down
Loading