Script properties are now preserved even when invalid (Fixes #768)

adriengivry · adriengivry · commit 433d6b5ffbbe · 2026-04-23T00:13:02.000-04:00
diff --git a/Sources/OvCore/src/OvCore/ECS/Components/Behaviour.cpp b/Sources/OvCore/src/OvCore/ECS/Components/Behaviour.cpp
@@ -64,9 +64,7 @@ void OvCore::ECS::Components::Behaviour::SetScript(std::unique_ptr<Scripting::Sc
 
 	if (!m_script || !m_script->IsValid())
 	{
-		m_scriptProperties.clear();
 		m_scriptDefaults.clear();
-		m_unlockedProperties.clear();
 		return;
 	}
 
@@ -180,6 +178,7 @@ void OvCore::ECS::Components::Behaviour::OnTriggerExit(Components::CPhysicalObje
 void OvCore::ECS::Components::Behaviour::OnSerialize(tinyxml2::XMLDocument & p_doc, tinyxml2::XMLNode * p_node)
 {
 	if (m_unlockedProperties.empty()) return;
+	if (!m_script->IsValid()) return;
 
 	tinyxml2::XMLNode* propsNode = p_doc.NewElement("script_properties");
 	p_node->InsertEndChild(propsNode);

Original file line number	Diff line number	Diff line change
`@@ -64,9 +64,7 @@ void OvCore::ECS::Components::Behaviour::SetScript(std::unique_ptr<Scripting::Sc`
`64`	`64`
`65`	`65`	`if (!m_script \|\| !m_script->IsValid())`
`66`	`66`	`{`
`67`		`- m_scriptProperties.clear();`
`68`	`67`	`m_scriptDefaults.clear();`
`69`		`- m_unlockedProperties.clear();`
`70`	`68`	`return;`
`71`	`69`	`}`
`72`	`70`
`@@ -180,6 +178,7 @@ void OvCore::ECS::Components::Behaviour::OnTriggerExit(Components::CPhysicalObje`
`180`	`178`	`void OvCore::ECS::Components::Behaviour::OnSerialize(tinyxml2::XMLDocument & p_doc, tinyxml2::XMLNode * p_node)`
`181`	`179`	`{`
`182`	`180`	`if (m_unlockedProperties.empty()) return;`
	`181`	`+ if (!m_script->IsValid()) return;`
`183`	`182`
`184`	`183`	`tinyxml2::XMLNode* propsNode = p_doc.NewElement("script_properties");`
`185`	`184`	`p_node->InsertEndChild(propsNode);`