Add actor copy/paste workflow in Hierarchy and Scene View (#734)

Author: Gopmyc

Sources/OvEditor/include/OvEditor/Core/Context.h

@@ -6,7 +6,9 @@
 
 #pragma once
 
+#include <cstdint>
 #include <filesystem>
+#include <variant>
 
 #include <OvAudio/Core/AudioEngine.h>
 #include <OvCore/ResourceManagement/MaterialManager.h>
@@ -35,6 +37,13 @@ namespace OvEditor::Core
 	class Context
 	{
 	public:
+		struct ActorCopyBuffer
+		{
+			uint64_t guid = 0;
+		};
+
+		using CopyBuffer = std::variant<std::monostate, ActorCopyBuffer>;
+
 		/**
 		* Constructor
 		* @param p_projectFolder (including the .ovproject file)
@@ -92,5 +101,7 @@ namespace OvEditor::Core
 		OvWindowing::Settings::WindowSettings windowSettings;
 
 		OvTools::Filesystem::IniFile projectSettings;
+
+		CopyBuffer copyBuffer;
 	};
 }

Sources/OvEditor/include/OvEditor/Core/EditorActions.h

@@ -228,6 +228,18 @@ namespace OvEditor::Core
 		#pragma endregion
 
 		#pragma region ACTOR_MANIPULATION
+		/**
+		* Copy the given actor in the editor copy buffer
+		* @param p_actor
+		*/
+		void CopyActor(OvCore::ECS::Actor& p_actor);
+
+		/**
+		* Paste the copied actor, optionally as a child of the given parent
+		* @param p_parent
+		*/
+		void PasteActor(OvCore::ECS::Actor* p_parent = nullptr);
+
 		/**
 		* Select an actor and show him in inspector
 		* @param p_target

Sources/OvEditor/src/OvEditor/Core/Editor.cpp

@@ -206,11 +206,40 @@ void OvEditor::Core::Editor::Update(float p_deltaTime)
 
 void OvEditor::Core::Editor::HandleGlobalShortcuts()
 {
+	auto& sceneView = EDITOR_PANEL(SceneView, "Scene View");
+	auto& hierarchy = EDITOR_PANEL(Hierarchy, "Hierarchy");
+	const bool isSceneViewFocused = sceneView.IsFocused();
+	const bool isHierarchyFocused = hierarchy.IsFocused();
+
 	// If the [Del] key is pressed while an actor is selected and the Scene View or Hierarchy is focused
-	if (m_context.inputManager->IsKeyPressed(OvWindowing::Inputs::EKey::KEY_DELETE) && EDITOR_EXEC(IsAnyActorSelected()) && (EDITOR_PANEL(SceneView, "Scene View").IsFocused() || EDITOR_PANEL(Hierarchy, "Hierarchy").IsFocused()))
+	if (m_context.inputManager->IsKeyPressed(OvWindowing::Inputs::EKey::KEY_DELETE) && EDITOR_EXEC(IsAnyActorSelected()) && (isSceneViewFocused || isHierarchyFocused))
 	{
 		EDITOR_EXEC(DestroyActor(EDITOR_EXEC(GetSelectedActor())));
 	}
+
+	const bool isControlPressed =
+		m_context.inputManager->GetKeyState(OvWindowing::Inputs::EKey::KEY_LEFT_CONTROL) == OvWindowing::Inputs::EKeyState::KEY_DOWN ||
+		m_context.inputManager->GetKeyState(OvWindowing::Inputs::EKey::KEY_RIGHT_CONTROL) == OvWindowing::Inputs::EKeyState::KEY_DOWN;
+
+	if (isControlPressed && (isSceneViewFocused || isHierarchyFocused))
+	{
+		if (m_context.inputManager->IsKeyPressed(OvWindowing::Inputs::EKey::KEY_C) && EDITOR_EXEC(IsAnyActorSelected()))
+		{
+			EDITOR_EXEC(CopyActor(EDITOR_EXEC(GetSelectedActor())));
+		}
+
+		if (m_context.inputManager->IsKeyPressed(OvWindowing::Inputs::EKey::KEY_V))
+		{
+			OvCore::ECS::Actor* parent = nullptr;
+
+			if (EDITOR_EXEC(IsAnyActorSelected()))
+			{
+				parent = &EDITOR_EXEC(GetSelectedActor());
+			}
+
+			EDITOR_EXEC(PasteActor(parent));
+		}
+	}
 }
 
 void OvEditor::Core::Editor::UpdateCurrentEditorMode(float p_deltaTime)

Sources/OvEditor/src/OvEditor/Core/EditorActions.cpp

@@ -800,32 +800,71 @@ void OvEditor::Core::EditorActions::DuplicateActor(OvCore::ECS::Actor & p_toDupl
 
 	newActor.SetID(idToUse);
 	newActor.SetGUID(guidToUse);
+	auto currentScene = m_context.sceneManager.GetCurrentScene();
 
 	if (p_forcedParent)
+	{
 		newActor.SetParent(*p_forcedParent);
-	else
+	}
+	else if (newActor.GetParentID() > 0)
 	{
-        auto currentScene = m_context.sceneManager.GetCurrentScene();
-
-        if (newActor.GetParentID() > 0)
-        {
-            if (auto found = currentScene->FindActorByID(newActor.GetParentID()); found)
-            {
-                newActor.SetParent(*found);
-            }
-        }
+		if (auto found = currentScene->FindActorByID(newActor.GetParentID()); found)
+		{
+			newActor.SetParent(*found);
+		}
+	}
 
-        const auto uniqueName = FindDuplicatedActorUniqueName(p_toDuplicate, newActor, *currentScene);
-        newActor.SetName(uniqueName);
+	if (p_focus || !p_forcedParent)
+	{
+		const auto uniqueName = FindDuplicatedActorUniqueName(p_toDuplicate, newActor, *currentScene);
+		newActor.SetName(uniqueName);
 	}
 
 	if (p_focus)
+	{
 		SelectActor(newActor);
+	}
 
 	for (auto& child : p_toDuplicate.GetChildren())
 		DuplicateActor(*child, &newActor, false);
 }
 
+void OvEditor::Core::EditorActions::CopyActor(OvCore::ECS::Actor& p_actor)
+{
+	m_context.copyBuffer = Context::ActorCopyBuffer{
+		.guid = p_actor.GetGUID()
+	};
+}
+
+void OvEditor::Core::EditorActions::PasteActor(OvCore::ECS::Actor* p_parent)
+{
+	const auto actorCopyBuffer = std::get_if<Context::ActorCopyBuffer>(&m_context.copyBuffer);
+	if (!actorCopyBuffer)
+	{
+		return;
+	}
+
+	const auto currentScene = m_context.sceneManager.GetCurrentScene();
+	if (!currentScene)
+	{
+		return;
+	}
+
+	if (const auto copiedActor = currentScene->FindActorByGUID(actorCopyBuffer->guid))
+	{
+		auto* destinationParent = p_parent;
+
+		// Pasting on the copied actor itself falls back to its current parent,
+		// preserving the "duplicate-like" behavior by default.
+		if (destinationParent && destinationParent->GetGUID() == copiedActor->GetGUID())
+		{
+			destinationParent = copiedActor->GetParent();
+		}
+
+		DuplicateActor(*copiedActor, destinationParent, true);
+	}
+}
+
 void OvEditor::Core::EditorActions::SelectActor(OvCore::ECS::Actor& p_target)
 {
 	EDITOR_PANEL(Panels::Inspector, "Inspector").FocusActor(p_target);

Sources/OvEditor/src/OvEditor/Panels/Hierarchy.cpp

@@ -55,12 +55,24 @@ class ActorContextualMenu : public OvUI::Plugins::ContextualMenu
 				EDITOR_EXEC(MoveToTarget(*m_target));
 			};
 
+			auto& copyButton = CreateWidget<OvUI::Widgets::Menu::MenuItem>("Copy");
+			copyButton.ClickedEvent += [this]
+			{
+				EDITOR_EXEC(CopyActor(*m_target));
+			};
+
 			auto& duplicateButton = CreateWidget<OvUI::Widgets::Menu::MenuItem>("Duplicate");
 			duplicateButton.ClickedEvent += [this]
 			{
 				EDITOR_EXEC(DelayAction(EDITOR_BIND(DuplicateActor, std::ref(*m_target), nullptr, true), 0));
 			};
 
+			auto& pasteButton = CreateWidget<OvUI::Widgets::Menu::MenuItem>("Paste");
+			pasteButton.ClickedEvent += [this]
+			{
+				EDITOR_EXEC(DelayAction(EDITOR_BIND(PasteActor, m_target), 0));
+			};
+
 			auto& deleteButton = CreateWidget<OvUI::Widgets::Menu::MenuItem>("Delete");
 			deleteButton.ClickedEvent += [this]
 			{
@@ -82,6 +94,14 @@ class ActorContextualMenu : public OvUI::Plugins::ContextualMenu
 				m_target->SetName(p_newName);
 			};
 		}
+		else
+		{
+			auto& pasteButton = CreateWidget<OvUI::Widgets::Menu::MenuItem>("Paste");
+			pasteButton.ClickedEvent += [this]
+			{
+				EDITOR_EXEC(DelayAction(EDITOR_BIND(PasteActor, nullptr), 0));
+			};
+		}
 
 		auto& createActor = CreateWidget<OvUI::Widgets::Menu::MenuList>("Create...");