Skip to content

Preview embedded model assets in asset browser#742

Merged
adriengivry merged 3 commits into
Overload-Technologies:mainfrom
Gopmyc:678
Apr 20, 2026
Merged

Preview embedded model assets in asset browser#742
adriengivry merged 3 commits into
Overload-Technologies:mainfrom
Gopmyc:678

Conversation

@Gopmyc

@Gopmyc Gopmyc commented Apr 19, 2026

Copy link
Copy Markdown
Contributor

Description

This PR makes model assets expandable in the Asset Browser to expose embedded materials and textures for quick preview.

Main changes:

  • Models are now expandable in the Asset Browser.
  • Embedded materials/textures are listed as read-only virtual entries.
  • Embedded textures context menu now exposes only Preview.
  • Embedded materials context menu now exposes:
    • Inspect (opens Material Editor)
    • Preview (opens Asset View)
  • Double-click on embedded entries still opens Asset View.
  • Open routing now recognizes embedded resource paths explicitly.

Related Issue(s)

Fixes #678

Review Guidance

Please focus review on:

  • Asset Browser behavior for expanded model nodes
  • Context menu behavior for embedded material/texture entries
  • Open behavior differences:
    • embedded material Inspect -> Material Editor
    • embedded material Preview -> Asset View
    • embedded texture Preview -> Asset View

Screenshots/GIFs

2 ---- 3

AI Usage Disclosure

Refactored code / Debugging

Checklist

  • My code follows the project's code style guidelines
  • When applicable, I have commented my code, particularly in hard-to-understand areas
  • When applicable, I have updated the documentation accordingly
  • My changes don't generate new warnings or errors
  • I have reviewed and take responsibility for all code in this PR (including any AI-assisted contributions)

@adriengivry adriengivry left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for putting that together!
A few comments:

  • To be consistent with other contextual menu, embedded files should only have an option to "Open", which would do the same as non-embedded files:
    • for materials: Preview + Open in material
    • for textures: Preview
  • Embedded assets (materials & textures) should be drag-and-droppable

@Gopmyc Gopmyc requested a review from adriengivry April 19, 2026 22:34
@Gopmyc

Gopmyc commented Apr 19, 2026

Copy link
Copy Markdown
Contributor Author

Looks good! Thanks for putting that together! A few comments:

  • To be consistent with other contextual menu, embedded files should only have an option to "Open", which would do the same as non-embedded files:

    • for materials: Preview + Open in material
    • for textures: Preview
  • Embedded assets (materials & textures) should be drag-and-droppable

Done ! I aligned embedded file menus to a single Open action and made embedded materials/textures drag-and-droppable

@adriengivry adriengivry merged commit 09109f6 into Overload-Technologies:main Apr 20, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Preview embedded assets (materials & textures) from a model

2 participants