Skip to content

Prevent repeated paste from nesting actors as children #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adriengivry merged 2 commits into from
Apr 23, 2026
+5 −5
Merged

Prevent repeated paste from nesting actors as children #766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f78d822
fix(editor): prevent actor paste from creating child hierarchy
Gopmyc Apr 23, 2026
03e710f
docs(editor): update PasteActor API contract comment
Gopmyc Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/OvEditor/include/OvEditor/Core/EditorActions.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ namespace OvEditor::Core
void CopyActor(OvCore::ECS::Actor& p_actor);

/**
* Paste the copied actor, optionally as a child of the given parent
* Paste the copied actor next to the given actor (same parent), or at root if null
* @param p_parent
*/
void PasteActor(OvCore::ECS::Actor* p_parent = nullptr);
Expand Down
8 changes: 4 additions & 4 deletions Sources/OvEditor/src/OvEditor/Core/EditorActions.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -909,11 +909,11 @@ void OvEditor::Core::EditorActions::PasteActor(OvCore::ECS::Actor* p_parent)
{
auto* destinationParent = p_parent;

// Pasting on the copied actor itself falls back to its current parent,
// preserving the "duplicate-like" behavior by default.
if (destinationParent && destinationParent->GetGUID() == copiedActor->GetGUID())
// Pasted actors are always inserted next to the target actor (same parent),
// never as children.
if (destinationParent)
{
destinationParent = copiedActor->GetParent();
destinationParent = destinationParent->GetParent();
}

DuplicateActor(*copiedActor, destinationParent, true);
Expand Down