Skip to content

Add Extract materials action to model contextual menu #767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adriengivry merged 2 commits into from
Apr 23, 2026
+42 −0
Merged

Add Extract materials action to model contextual menu #767

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
048139c
feat(editor): add model embedded material extraction
Gopmyc Apr 23, 2026
bd4e7b3
feat(editor): add extract materials model menu action
Gopmyc Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions Sources/OvEditor/src/OvEditor/Panels/AssetBrowser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -680,6 +680,42 @@ namespace
}
}

void ExtractMaterialFiles()
{
auto& modelManager = OVSERVICE(OvCore::ResourceManagement::ModelManager);
auto& materialManager = OVSERVICE(OvCore::ResourceManagement::MaterialManager);
const std::string resourcePath = EDITOR_EXEC(GetResourcePath(filePath.string(), m_protected));

if (auto model = modelManager.GetResource(resourcePath))
{
const auto& embeddedMaterials = model->GetEmbeddedMaterials();
const auto& materialNames = model->GetMaterialNames();

for (size_t materialIndex = 0; materialIndex < embeddedMaterials.size(); ++materialIndex)
{
const std::string embeddedMaterialPath = OvRendering::Resources::Parsers::MakeEmbeddedMaterialPath(
resourcePath,
static_cast<uint32_t>(materialIndex)
);

auto* embeddedMaterial = materialManager.GetResource(embeddedMaterialPath);
if (!embeddedMaterial)
{
continue;
}

const bool hasNamedSlot = materialIndex < materialNames.size() && !materialNames[materialIndex].empty();
const std::string materialName = hasNamedSlot
? materialNames[materialIndex]
: std::format("embedded_material_{}", materialIndex);

const auto finalPath = FindAvailableFilePath(filePath.parent_path() / (materialName + ".ovmat"));
OvCore::Resources::Loaders::MaterialLoader::Save(*embeddedMaterial, finalPath.string());
DuplicateEvent.Invoke(finalPath);
}
}
}

void CreateMaterialCreationOption(OvUI::Internal::WidgetContainer& p_root, const std::string_view p_materialName)
{
const std::string materialName{ p_materialName };
Expand Down Expand Up @@ -708,9 +744,15 @@ namespace
if (!m_protected)
{
auto& generateMaterialsMenu = CreateWidget<OvUI::Widgets::Menu::MenuList>("Generate materials...");
auto& extractMaterialsAction = CreateWidget<OvUI::Widgets::Menu::MenuItem>("Extract materials");

CreateMaterialCreationOption(generateMaterialsMenu, "Standard");
CreateMaterialCreationOption(generateMaterialsMenu, "Unlit");

extractMaterialsAction.ClickedEvent += [this]
{
ExtractMaterialFiles();
};
}

FileContextualMenu::CreateList();
Expand Down