[ENHANCEMENT] Add title fields to STAC catalogs/collections#62
Merged
John McCall (lowlydba) merged 6 commits intoMay 14, 2026
Conversation
Set title attributes on STAC Catalog and Collection objects so generated child links include a title. Pass the title when adding child collections to ensure link.title is populated. Add a unit test to verify theme and child collection titles are present, and add a title to the overture releases catalog in the CLI. Signed-off-by: John McCall <john@overturemaps.org>
Signed-off-by: John McCall <john@overturemaps.org>
🗺️ OMF STAC preview is live!
Note ♻️ This preview updates automatically with each push to this PR. |
Set the title field on the root Catalog in tests to match the CLI structure and ensure the catalog has a title during test setup. Signed-off-by: John McCall <john@overturemaps.org>
Signed-off-by: John McCall <john@overturemaps.org>
Signed-off-by: John McCall <john@overturemaps.org>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds title fields to STAC Catalog/Collection objects and child links so generated catalogs comply with the STAC best practice flagged by stac-check.
Changes:
- Set
titleon themeCatalog, typeCollection, and the root "Overture Releases" catalog (in both CLI and test setup). - Pass
title=type_namewhen callingtheme_catalog.add_child(...)so child links have a populatedtitle. - Add a unit test verifying titles are present on the theme catalog, child collection, and child links.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/overture_stac/overture_stac.py | Adds title to theme catalog and type collection; passes title when adding child. |
| src/overture_stac/cli.py | Adds title="Overture Releases" to the root catalog. |
| tests/setup_test_catalog.py | Mirrors the root-catalog title change for the test catalog. |
| tests/test_process_theme_worker.py | Adds test_child_links_have_titles; inadvertently removes the TestBuildReleaseCatalog class declaration. |
| uv.lock | Bumps overture-stac version to 1.0.7. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: John McCall <john@lowlydba.com>
Francisco Jiménez (jjcfrancisco)
approved these changes
May 14, 2026
Francisco Jiménez (jjcfrancisco)
left a comment
Member
There was a problem hiding this comment.
Nice
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
link.titleis populated.Validation
Before, when run on main, we see this in the stac-check output:
And now, this is no longer flagged by stac-check in CI. Our staging build of the catalog also shows that
titleis populated now in all uses oflink(prior was just some):