Develop (#43)

* #26 #25

* code style fixed (#28)

* Feature/http client tests code quilty (#30)

* code style fixed

* #29 #26

* code-quilty

* code-quilty (#32)

* code style fixs

* release 0.0.23 updated

* release 0.0.23 updated

* #23

* #25

* #25 (#35)

* improve coverage

* improve coverage

* improve coverage

* improve coverage

* Feature/imporve coverage (#37)

* #25

* improve coverage

* improve coverage

* improve coverage

* improve coverage

* #39 (#40)

* Feature/validation coverage (#42)

* #39

* #41

Author: OyaAIProd

pom.xml

@@ -27,6 +27,7 @@
         <java.version>1.7</java.version>
 
         <gson.version>2.8.0</gson.version>
+        <javax.validation.api.version>1.0.0.GA</javax.validation.api.version>
         <jackson.version>2.8.5</jackson.version>
         <commons.lang.version>3.5</commons.lang.version>
         <slf4.version>1.7.21</slf4.version>
@@ -81,6 +82,12 @@
             <version>${commons.lang.version}</version>
         </dependency>
 
+        <dependency>
+            <groupId>javax.validation</groupId>
+            <artifactId>validation-api</artifactId>
+            <version>${javax.validation.api.version}</version>
+        </dependency>
+
         <dependency>
             <groupId>org.apache.httpcomponents</groupId>
             <artifactId>httpclient</artifactId>

src/main/java/io/github/rhkiswani/javaff/detector/ApiDetectorUtil.java

@@ -35,8 +35,6 @@ public class ApiDetectorUtil {
     private static final Boolean isApacheHttpClientAvailable = ApiDetectorFactory.getDetector().isAvailable(APACHE_HTTPCLIENT_API_METADATA);
 
 
-    private ApiDetectorUtil(){}
-
     public static Boolean isJPAAvailable() {
         return isJPAAvailable;
     }

src/main/java/io/github/rhkiswani/javaff/exceptions/ExceptionUtil.java

@@ -24,8 +24,6 @@
  */
 public class ExceptionUtil {
 
-    private ExceptionUtil(){}
-
     public static void handle(Throwable t){
         if (t == null){
             throw new IllegalParamException(SmartException.NULL_VAL, "Exception");

src/main/java/io/github/rhkiswani/javaff/exceptions/SmartException.java

@@ -35,6 +35,7 @@ public class SmartException extends RuntimeException{
     public static final String NEGATIVE_VAL = "NEGATIVE_VAL";
     public static final String HTTP_ERROR = "HTTP_ERROR";
     public static final String NO_IMPLEMENTATION_FOUND = "NO_IMPLEMENTATION_FOUND";
+    public static final String NO_IMPLEMENTATION_FOUND_WITH_NO_LINK = "NO_IMPLEMENTATION_FOUND_WITH_NO_LINK";
 
     private Object[] errorMsgParams = null;
 

src/main/java/io/github/rhkiswani/javaff/factory/AbstractFactory.java

@@ -18,6 +18,8 @@
 import io.github.rhkiswani.javaff.exceptions.SmartException;
 import io.github.rhkiswani.javaff.factory.exceptions.NoImplementationFoundException;
 import io.github.rhkiswani.javaff.lang.exceptions.IllegalParamException;
+import io.github.rhkiswani.javaff.lang.utils.ObjectUtils;
+import io.github.rhkiswani.javaff.lang.utils.StringUtils;
 
 import java.util.Collection;
 import java.util.LinkedHashMap;
@@ -39,24 +41,37 @@ public void add(Class targetClass, T t){
         if (map.get(targetClass) != null){
             throw new IllegalParamException(SmartException.ALREADY_EXIST, targetClass, "please use overrideImp method instated");
         }
+        if (targetClass.isPrimitive()){
+            targetClass = ObjectUtils.primitiveToWrapper(targetClass);
+        }
         map.put(targetClass, t);
     }
 
     public void overrideImp(Class targetClass, T t){
+        if (targetClass.isPrimitive()){
+            targetClass = ObjectUtils.primitiveToWrapper(targetClass);
+        }
         map.put(targetClass, t);
     }
 
     public T remove(Class targetClass){
+        if (targetClass.isPrimitive()){
+            targetClass = ObjectUtils.primitiveToWrapper(targetClass);
+        }
         return map.remove(targetClass);
     }
 
-    protected T create(Class targetClass){
-        if (targetClass == null){
+    protected T create(Class clazz){
+        if (clazz == null){
             throw new IllegalParamException(SmartException.NULL_VAL, "Target Class");
         }
         if (userDefaultImpl != null){
             return userDefaultImpl;
         }
+        Class targetClass = clazz;
+        if (targetClass.isPrimitive()){
+            targetClass = ObjectUtils.primitiveToWrapper(targetClass);
+        }
         Set<Class> classSet = map.keySet();
         Class[] keys = classSet.toArray(new Class[classSet.size()]);
         for (int i = keys.length - 1 ; i >=0 ; i--){
@@ -77,10 +92,14 @@ public void setDefault(T userDefaultImpl) {
     }
 
     protected T getDefault(Class targetClazz) {
-        throw new NoImplementationFoundException(SmartException.NO_IMPLEMENTATION_FOUND, this.getClass().getSimpleName(), this.getClass().getSimpleName(), getDefaultImplementationUrl());
+        if (StringUtils.isNotEmpty(getDefaultImplementationUrl())){
+            throw new NoImplementationFoundException(SmartException.NO_IMPLEMENTATION_FOUND, targetClazz, this.getClass().getSimpleName(), getDefaultImplementationUrl());
+        } else {
+            throw new NoImplementationFoundException(SmartException.NO_IMPLEMENTATION_FOUND_WITH_NO_LINK, targetClazz, this.getClass().getSimpleName());
+        }
     }
 
     protected String getDefaultImplementationUrl(){
-        return "https://mvnrepository.com";
+        return "";
     }
 }

src/main/java/io/github/rhkiswani/javaff/format/DefaultFormatter.java

@@ -33,15 +33,8 @@ protected O format(I i, Object[] params) throws FormatException {
             return null;
         }
         if (!ArraysUtils.isEmpty(params)){
-            try {
-                ArraysUtils.replace(params, null, "");
-                return formatVal(i, params);
-            } catch (FormatException e){
-                throw e;
-            } catch (Throwable t ){
-                throw new FormatException(t.getMessage());
-            }
-
+            ArraysUtils.replace(params, null, "");
+            return formatVal(i, params);
         }
         return formatVal(i, new Object[]{});
     }

src/main/java/io/github/rhkiswani/javaff/format/FormatFactory.java

@@ -43,7 +43,7 @@ protected Formatter getDefault(Class targetClazz){
         return new StringFormatter();
     }
 
-    public static Formatter getFormatter(Class aClass) {
+    public static <I, O> Formatter<I, O> getFormatter(Class aClass) {
         return instance.create(aClass);
     }
 }

src/main/java/io/github/rhkiswani/javaff/format/FormatUtil.java

@@ -22,8 +22,6 @@
  */
 public class FormatUtil {
 
-    private FormatUtil(){}
-
     public static String formatString(String str, Object... params){
         return format(str, params);
     }

src/main/java/io/github/rhkiswani/javaff/httpclient/ApacheHttpClient.java

@@ -139,7 +139,7 @@ public Map<String, String> head(String url, Map<String, String> params, Map<Stri
             HttpHead method = new HttpHead(url);
             CloseableHttpClient client = prepareRequest(method, params);
             setHeaders(method, headers);
-            HttpResponse response= client.execute(method);
+            HttpResponse response = client.execute(method);
             Header[] s = response.getAllHeaders();
             Map<String, String> returnedHeaders = new HashMap<>();
             for (Header header : s) {
@@ -162,10 +162,6 @@ public Map<String, String> options(String url, Map<String, String> params, Map<S
         return head(url, params, headers);
     }
 
-    @Override
-    public String patch(String url, Map<String, String> params, Map<String, String> headers) throws HttpClientException {
-        return doRequest(new HttpPatch(url), params, headers);
-    }
 
     @Override
     public String patchJson(String url, String json, Map<String, String> headers) throws HttpClientException {

src/main/java/io/github/rhkiswani/javaff/httpclient/HttpClient.java

@@ -42,7 +42,5 @@ public interface HttpClient {
 
     Map<String, String> options(String url, Map<String, String> params, Map<String, String> headers) throws HttpClientException;
 
-    String patch(String url, Map<String, String> params, Map<String, String> headers) throws HttpClientException;
-
     String patchJson(String url, String json, Map<String, String> headers) throws HttpClientException;
 }