Skip to content

Commit 333a797

Browse files
committed
Fix SignalClassification tests for relaxed 2.4 GHz thresholds
1 parent ca846e9 commit 333a797

1 file changed

Lines changed: 11 additions & 11 deletions

File tree

tests/NetworkOptimizer.WiFi.Tests/SignalClassificationTests.cs

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,10 @@ public void GetSignalClass_5GHz_CorrectClassification(int dbm, RadioBand band, s
2222

2323
[Theory]
2424
[InlineData(-45, RadioBand.Band2_4GHz, "signal-excellent")]
25-
[InlineData(-55, RadioBand.Band2_4GHz, "signal-good")]
26-
[InlineData(-65, RadioBand.Band2_4GHz, "signal-fair")]
27-
[InlineData(-72, RadioBand.Band2_4GHz, "signal-weak")]
28-
[InlineData(-80, RadioBand.Band2_4GHz, "signal-poor")]
25+
[InlineData(-60, RadioBand.Band2_4GHz, "signal-good")]
26+
[InlineData(-70, RadioBand.Band2_4GHz, "signal-fair")]
27+
[InlineData(-76, RadioBand.Band2_4GHz, "signal-weak")]
28+
[InlineData(-85, RadioBand.Band2_4GHz, "signal-poor")]
2929
public void GetSignalClass_2_4GHz_CorrectClassification(int dbm, RadioBand band, string expected)
3030
{
3131
SignalClassification.GetSignalClass(dbm, band).Should().Be(expected);
@@ -56,8 +56,8 @@ public void SameSignal_ClassifiedDifferentlyByBand()
5656
[Fact]
5757
public void SameSignal_Minus68_ClassifiedDifferentlyByBand()
5858
{
59-
// -68 dBm: weak on 2.4 GHz, good on 5 GHz, good on 6 GHz
60-
SignalClassification.GetSignalClass(-68, RadioBand.Band2_4GHz).Should().Be("signal-weak");
59+
// -68 dBm: fair on 2.4 GHz, good on 5 GHz, good on 6 GHz
60+
SignalClassification.GetSignalClass(-68, RadioBand.Band2_4GHz).Should().Be("signal-fair");
6161
SignalClassification.GetSignalClass(-68, RadioBand.Band5GHz).Should().Be("signal-good");
6262
SignalClassification.GetSignalClass(-68, RadioBand.Band6GHz).Should().Be("signal-good");
6363
}
@@ -107,8 +107,8 @@ public void NullableSignalWithValue_ReturnsCorrectClass()
107107
// --- IsWeakSignal ---
108108

109109
[Theory]
110-
[InlineData(-67, RadioBand.Band2_4GHz, false)] // exactly at threshold = not weak
111-
[InlineData(-68, RadioBand.Band2_4GHz, true)]
110+
[InlineData(-73, RadioBand.Band2_4GHz, false)] // exactly at threshold = not weak
111+
[InlineData(-74, RadioBand.Band2_4GHz, true)]
112112
[InlineData(-78, RadioBand.Band5GHz, false)]
113113
[InlineData(-79, RadioBand.Band5GHz, true)]
114114
[InlineData(-87, RadioBand.Band6GHz, false)]
@@ -130,8 +130,8 @@ public void IsWeakSignal_SameSignalDifferentBands()
130130
// --- IsCriticalSignal ---
131131

132132
[Theory]
133-
[InlineData(-75, RadioBand.Band2_4GHz, false)]
134-
[InlineData(-76, RadioBand.Band2_4GHz, true)]
133+
[InlineData(-80, RadioBand.Band2_4GHz, false)]
134+
[InlineData(-81, RadioBand.Band2_4GHz, true)]
135135
[InlineData(-85, RadioBand.Band5GHz, false)]
136136
[InlineData(-86, RadioBand.Band5GHz, true)]
137137
[InlineData(-92, RadioBand.Band6GHz, false)]
@@ -144,7 +144,7 @@ public void IsCriticalSignal_BandAwareThresholds(int dbm, RadioBand band, bool e
144144
// --- GetWeakThreshold ---
145145

146146
[Theory]
147-
[InlineData(RadioBand.Band2_4GHz, -67)]
147+
[InlineData(RadioBand.Band2_4GHz, -73)]
148148
[InlineData(RadioBand.Band5GHz, -78)]
149149
[InlineData(RadioBand.Band6GHz, -87)]
150150
public void GetWeakThreshold_ReturnsBandSpecificValues(RadioBand band, int expected)

0 commit comments

Comments
 (0)