Fix session expiry causing "No WAN Connections Detected" on SQM page (#522)

Several API methods (GetDevicesRawJsonAsync, GetSiteHealthAsync,
GetSettingsRawAsync, GetCurrentChannelDataAsync, GetLegacyFirewallRulesRawAsync)
made direct HTTP calls without re-authentication on 401/403, unlike
ExecuteApiCallAsync which handles this. When the UniFi session expired,
these methods silently returned null, causing the SQM page to show
"No WAN Connections Detected" and lock the user out of configuration.

Added the same re-auth-and-retry pattern used by ExecuteApiCallAsync
to all five methods.

Fixes #516

Author: tvancott42

src/NetworkOptimizer.UniFi/UniFiApiClient.cs

@@ -605,6 +605,23 @@ public async Task<List<UniFiDeviceResponse>> GetDevicesAsync(CancellationToken c
         {
             var response = await _httpClient!.GetAsync(BuildApiPath("stat/device"), cancellationToken);
 
+            // Handle authentication failures (session expired)
+            if (response.StatusCode == HttpStatusCode.Unauthorized ||
+                response.StatusCode == HttpStatusCode.Forbidden)
+            {
+                _logger.LogWarning("Got {StatusCode} fetching raw device JSON, re-authenticating...", response.StatusCode);
+                _isAuthenticated = false;
+
+                if (!await LoginAsync(cancellationToken))
+                {
+                    _logger.LogError("Re-authentication failed while fetching raw device JSON");
+                    return null;
+                }
+
+                // Retry with new authentication
+                response = await _httpClient!.GetAsync(BuildApiPath("stat/device"), cancellationToken);
+            }
+
             if (response.IsSuccessStatusCode)
             {
                 var json = await response.Content.ReadAsStringAsync(cancellationToken);
@@ -934,6 +951,23 @@ public async Task<List<UniFiFirewallRule>> GetFirewallRulesAsync(CancellationTok
         try
         {
             var response = await _httpClient!.GetAsync(BuildApiPath("rest/firewallrule"), cancellationToken);
+
+            // Handle authentication failures (session expired)
+            if (response.StatusCode == HttpStatusCode.Unauthorized ||
+                response.StatusCode == HttpStatusCode.Forbidden)
+            {
+                _logger.LogWarning("Got {StatusCode} fetching legacy firewall rules, re-authenticating...", response.StatusCode);
+                _isAuthenticated = false;
+
+                if (!await LoginAsync(cancellationToken))
+                {
+                    _logger.LogError("Re-authentication failed while fetching legacy firewall rules");
+                    return null;
+                }
+
+                response = await _httpClient!.GetAsync(BuildApiPath("rest/firewallrule"), cancellationToken);
+            }
+
             response.EnsureSuccessStatusCode();
 
             var json = await response.Content.ReadAsStringAsync(cancellationToken);
@@ -1253,6 +1287,22 @@ public async Task<bool> UpdateNetworkConfigAsync(
         {
             var response = await _httpClient!.GetAsync(BuildApiPath("stat/health"), cancellationToken);
 
+            // Handle authentication failures (session expired)
+            if (response.StatusCode == HttpStatusCode.Unauthorized ||
+                response.StatusCode == HttpStatusCode.Forbidden)
+            {
+                _logger.LogWarning("Got {StatusCode} fetching site health, re-authenticating...", response.StatusCode);
+                _isAuthenticated = false;
+
+                if (!await LoginAsync(cancellationToken))
+                {
+                    _logger.LogError("Re-authentication failed while fetching site health");
+                    return null;
+                }
+
+                response = await _httpClient!.GetAsync(BuildApiPath("stat/health"), cancellationToken);
+            }
+
             if (response.IsSuccessStatusCode)
             {
                 var json = await response.Content.ReadAsStringAsync(cancellationToken);
@@ -1432,6 +1482,22 @@ public async Task<bool> UpdateTrafficRouteAsync(
         {
             var response = await _httpClient!.GetAsync(BuildApiPath("rest/setting"), cancellationToken);
 
+            // Handle authentication failures (session expired)
+            if (response.StatusCode == HttpStatusCode.Unauthorized ||
+                response.StatusCode == HttpStatusCode.Forbidden)
+            {
+                _logger.LogWarning("Got {StatusCode} fetching settings, re-authenticating...", response.StatusCode);
+                _isAuthenticated = false;
+
+                if (!await LoginAsync(cancellationToken))
+                {
+                    _logger.LogError("Re-authentication failed while fetching settings");
+                    return null;
+                }
+
+                response = await _httpClient!.GetAsync(BuildApiPath("rest/setting"), cancellationToken);
+            }
+
             if (response.IsSuccessStatusCode)
             {
                 var json = await response.Content.ReadAsStringAsync(cancellationToken);
@@ -1461,6 +1527,22 @@ public async Task<bool> UpdateTrafficRouteAsync(
         {
             var response = await _httpClient!.GetAsync(BuildApiPath("stat/current-channel"), cancellationToken);
 
+            // Handle authentication failures (session expired)
+            if (response.StatusCode == HttpStatusCode.Unauthorized ||
+                response.StatusCode == HttpStatusCode.Forbidden)
+            {
+                _logger.LogWarning("Got {StatusCode} fetching current channel data, re-authenticating...", response.StatusCode);
+                _isAuthenticated = false;
+
+                if (!await LoginAsync(cancellationToken))
+                {
+                    _logger.LogError("Re-authentication failed while fetching current channel data");
+                    return null;
+                }
+
+                response = await _httpClient!.GetAsync(BuildApiPath("stat/current-channel"), cancellationToken);
+            }
+
             if (response.IsSuccessStatusCode)
             {
                 var json = await response.Content.ReadAsStringAsync(cancellationToken);