Skip to content

Commit 7491869

Browse files
committed
TODO: relocate DefaultSiteSlug constant to a shared project
1 parent 3a785b3 commit 7491869

1 file changed

Lines changed: 5 additions & 0 deletions

File tree

TODO.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -614,6 +614,11 @@ Goal: keep global channels applying everywhere, but let a site add its OWN addit
614614
- **Fix:** Replace with an enum `DnatCoverageType` for type safety and discoverability
615615
- **Scope:** `DnatDnsAnalyzer.cs` only - fully self-contained
616616

617+
### Relocate DefaultSiteSlug Constant to a Shared Project
618+
- **Issue:** `SiteManagementService.DefaultSiteSlug` (`"main"`) lives in `NetworkOptimizer.Web`, but lower-level projects that reference only `NetworkOptimizer.Core` need the same value. `AlertProcessingService.ResolveSourceUrl` (`NetworkOptimizer.Alerts`) can't reference it - the dependency points the wrong way - so it hardcodes the literal `"main"` with a comment.
619+
- **Fix:** Move the constant down into a shared low-level home (`NetworkOptimizer.Core`), then repoint every reference (`SiteManagementService`, `SiteContextService`, `AlertProcessingService`, and any others).
620+
- **Scope:** Multiple projects; small but touches DI/reference sites, so needs a rebuild + test pass. Not urgent - the literal is correct as long as the constant stays `"main"`.
621+
617622
### ThirdPartyDnsDetector Probe Method Duplication
618623
- **Issue:** Two overloads of `TryProbePiholeEndpointAsync` and `TryProbeAdGuardHomeEndpointAsync` - one takes a full URL, one takes IP+port+scheme. The logic is nearly identical.
619624
- **Fix:** Unify into a single method that takes a URL string. The IP+port caller can construct the URL before calling.

0 commit comments

Comments
 (0)