Feat: Implement directional light class#134
Merged
github-actions[bot] merged 5 commits intoNov 25, 2025
Merged
Conversation
ryu-kyu
added
enhancement
ryu-kyu
changed the title
su-ah
requested changes
Nov 12, 2025
|
|
||
| DirLight::~DirLight() = default; | ||
|
|
||
| void DirLight::update() {} |
Collaborator
There was a problem hiding this comment.
this will be called by scene to tell the emitter to actually update its shadow map, check resources for what it needs to do
def the hardest part, so feel free to ask for help from myself or anyone else
Collaborator
Author
There was a problem hiding this comment.
In the resources, it's just marked with a red star. As far as I know, there's no guidance on this.
Collaborator
|
oh btw, can u move ur glm -> eigen helper into lightprops so the others can use it too? |
Collaborator
|
dont mind the merge conflicts btw, ill deal w those |
ryu-kyu
force-pushed
the
feat/impl-dir-light-class
branch
from
01acfa6 to
34c8a01
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes
confShadowMap, to accept shader as argument so thatshader.use()is called beforeconfShadowMap().Tests
Builds fine.