Fix REST API validation failures for omitted fields#1115
Merged
Conversation
cjqian
approved these changes
May 12, 2026
Collaborator
|
I created #1118 to track the upstream problem. Is there an easy way to test for this at PR time? I believe we already run Firebase emulators for testing the functions. We should be able to also exercise the Python CLI at this time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit f27f7fc introduced strict TypeBox
Value.Checkvalidation for REST API endpoints. This caused Python client payloads (which omit fields rather than explicitly sendingnulldue to Pydantic'sexclude_none=True) to be rejected withExpected union value400 errors for any fields defined strictly asType.Union([Type.Null(), ...]).This commit fixes the mismatch by wrapping all nullable TypeBox schemas in
Type.Optional(), allowing clients to perform partial updates or omit empty fields cleanly while maintaining strict runtime typing.