Skip to content

Sync dependencies with odlparent 14.3.1 - #331

Draft
Tobianas wants to merge 4 commits into
PANTHEONtech:22.xfrom
Tobianas:22.x_titantium_sr2_sync
Draft

Sync dependencies with odlparent 14.3.1#331
Tobianas wants to merge 4 commits into
PANTHEONtech:22.xfrom
Tobianas:22.x_titantium_sr2_sync

Conversation

@Tobianas

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several test files to accommodate changes in the createClient API by adding a no-op SSHNegotiatedAlgListener. It also updates YANG model revision dates for network topology and device modules, and increments the maven-surefire-plugin version to 3.5.5. Feedback was provided to refactor the repeated no-op listener lambdas into a shared constant to improve maintainability and reduce code duplication across the test suite.

Comment on lines +111 to +114
dispatcher.createClient(createSHHConfig(sessionListener), (SSHNegotiatedAlgListener) (kexAlgorithm,
hostKey, encryption, mac) -> {
// No-op
})

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The SSHNegotiatedAlgListener lambda is verbose and repeated across multiple test methods and files. Extracting this lambda into a private static final field would improve readability and reduce code duplication. This enhances the maintainability of the test code.

Consider defining a constant like this:

private static final SSHNegotiatedAlgListener NOOP_SSH_NEGOTIATED_ALG_LISTENER =
    (kexAlgorithm, hostKey, encryption, mac) -> {
        // No-op
    };

Then, you can use NOOP_SSH_NEGOTIATED_ALG_LISTENER directly in the createClient calls.

                dispatcher.createClient(createSHHConfig(sessionListener), NOOP_SSH_NEGOTIATED_ALG_LISTENER)

@ihrasko
ihrasko force-pushed the 22.x_titantium_sr2_sync branch from e63a6bc to e962cbb Compare April 10, 2026 12:30
opendaylight/netconf@45afbb4

JIRA: LIGHTY-428
Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech>
opendaylight/netconf@c1b8141

JIRA: LIGHTY-428
Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech>
opendaylight/netconf@db7b206

JIRA: LIGHTY-428
Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech>
@Tobianas
Tobianas force-pushed the 22.x_titantium_sr2_sync branch from e962cbb to e56b8be Compare April 13, 2026 18:39
@Tobianas
Tobianas marked this pull request as draft April 13, 2026 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant