Sync dependencies with odlparent 14.3.1 - #331
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates several test files to accommodate changes in the createClient API by adding a no-op SSHNegotiatedAlgListener. It also updates YANG model revision dates for network topology and device modules, and increments the maven-surefire-plugin version to 3.5.5. Feedback was provided to refactor the repeated no-op listener lambdas into a shared constant to improve maintainability and reduce code duplication across the test suite.
| dispatcher.createClient(createSHHConfig(sessionListener), (SSHNegotiatedAlgListener) (kexAlgorithm, | ||
| hostKey, encryption, mac) -> { | ||
| // No-op | ||
| }) |
There was a problem hiding this comment.
The SSHNegotiatedAlgListener lambda is verbose and repeated across multiple test methods and files. Extracting this lambda into a private static final field would improve readability and reduce code duplication. This enhances the maintainability of the test code.
Consider defining a constant like this:
private static final SSHNegotiatedAlgListener NOOP_SSH_NEGOTIATED_ALG_LISTENER =
(kexAlgorithm, hostKey, encryption, mac) -> {
// No-op
};Then, you can use NOOP_SSH_NEGOTIATED_ALG_LISTENER directly in the createClient calls.
dispatcher.createClient(createSHHConfig(sessionListener), NOOP_SSH_NEGOTIATED_ALG_LISTENER)e63a6bc to
e962cbb
Compare
opendaylight/netconf@45afbb4 JIRA: LIGHTY-428 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech>
opendaylight/netconf@c1b8141 JIRA: LIGHTY-428 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech>
opendaylight/netconf@db7b206 JIRA: LIGHTY-428 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech>
https://github.com/apache/maven-surefire/releases/tag/surefire-3.5.4 https://github.com/apache/maven-surefire/releases/tag/surefire-3.5.5 JIRA: LIGHTY-415 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech> (cherry picked from commit 0a4a358)
e962cbb to
e56b8be
Compare
No description provided.