REST API: Fix finalize endpoint tests in Attachments controller.

Enable client-side media processing in the three `test_finalize_item*`
tests so the `/finalize` route is registered before dispatching requests.
Without this, the route does not exist and all assertions fail with
`rest_no_route`.

Extracts the repeated filter-and-reinitialize pattern into a shared
`enable_client_side_media_processing()` helper, used by both the
sideload and finalize tests.

Follow-up to [61982].



git-svn-id: https://develop.svn.wordpress.org/trunk@61984 602fd350-edb4-49c9-b593-d223f7449a82

Author: gziolo

tests/phpunit/tests/rest-api/rest-attachments-controller.php

@@ -194,6 +194,18 @@ public function tear_down() {
 		parent::tear_down();
 	}
 
+	/**
+	 * Enables client-side media processing and reinitializes the REST server
+	 * so that the sideload and finalize routes are registered.
+	 */
+	private function enable_client_side_media_processing(): void {
+		add_filter( 'wp_client_side_media_processing_enabled', '__return_true' );
+
+		global $wp_rest_server;
+		$wp_rest_server = new Spy_REST_Server();
+		do_action( 'rest_api_init', $wp_rest_server );
+	}
+
 	public function test_register_routes() {
 		$routes = rest_get_server()->get_routes();
 		$this->assertArrayHasKey( '/wp/v2/media', $routes );
@@ -3236,11 +3248,7 @@ static function ( $data ) use ( &$captured_data ) {
 	 * @requires function imagejpeg
 	 */
 	public function test_sideload_scaled_image() {
-		add_filter( 'wp_client_side_media_processing_enabled', '__return_true' );
-		// Reinitialize REST server so the sideload route is registered.
-		global $wp_rest_server;
-		$wp_rest_server = new Spy_REST_Server();
-		do_action( 'rest_api_init', $wp_rest_server );
+		$this->enable_client_side_media_processing();
 
 		wp_set_current_user( self::$author_id );
 
@@ -3295,11 +3303,7 @@ public function test_sideload_scaled_image() {
 	 * @requires function imagejpeg
 	 */
 	public function test_sideload_scaled_image_requires_auth() {
-		add_filter( 'wp_client_side_media_processing_enabled', '__return_true' );
-		// Reinitialize REST server so the sideload route is registered.
-		global $wp_rest_server;
-		$wp_rest_server = new Spy_REST_Server();
-		do_action( 'rest_api_init', $wp_rest_server );
+		$this->enable_client_side_media_processing();
 
 		wp_set_current_user( self::$author_id );
 
@@ -3330,11 +3334,7 @@ public function test_sideload_scaled_image_requires_auth() {
 	 * @ticket 64737
 	 */
 	public function test_sideload_route_includes_scaled_enum() {
-		add_filter( 'wp_client_side_media_processing_enabled', '__return_true' );
-		// Reinitialize REST server so the sideload route is registered.
-		global $wp_rest_server;
-		$wp_rest_server = new Spy_REST_Server();
-		do_action( 'rest_api_init', $wp_rest_server );
+		$this->enable_client_side_media_processing();
 
 		$server = rest_get_server();
 		$routes = $server->get_routes();
@@ -3358,11 +3358,7 @@ public function test_sideload_route_includes_scaled_enum() {
 	 * @requires function imagejpeg
 	 */
 	public function test_sideload_scaled_unique_filename() {
-		add_filter( 'wp_client_side_media_processing_enabled', '__return_true' );
-		// Reinitialize REST server so the sideload route is registered.
-		global $wp_rest_server;
-		$wp_rest_server = new Spy_REST_Server();
-		do_action( 'rest_api_init', $wp_rest_server );
+		$this->enable_client_side_media_processing();
 
 		wp_set_current_user( self::$author_id );
 
@@ -3398,11 +3394,7 @@ public function test_sideload_scaled_unique_filename() {
 	 * @requires function imagejpeg
 	 */
 	public function test_sideload_scaled_unique_filename_conflict() {
-		add_filter( 'wp_client_side_media_processing_enabled', '__return_true' );
-		// Reinitialize REST server so the sideload route is registered.
-		global $wp_rest_server;
-		$wp_rest_server = new Spy_REST_Server();
-		do_action( 'rest_api_init', $wp_rest_server );
+		$this->enable_client_side_media_processing();
 
 		wp_set_current_user( self::$author_id );
 
@@ -3456,6 +3448,8 @@ public function test_sideload_scaled_unique_filename_conflict() {
 	 * @requires function imagejpeg
 	 */
 	public function test_finalize_item(): void {
+		$this->enable_client_side_media_processing();
+
 		wp_set_current_user( self::$author_id );
 
 		// Create an attachment.
@@ -3508,6 +3502,8 @@ function ( array $metadata, int $id, string $context ) use ( &$filter_metadata,
 	 * @requires function imagejpeg
 	 */
 	public function test_finalize_item_requires_auth(): void {
+		$this->enable_client_side_media_processing();
+
 		wp_set_current_user( self::$author_id );
 
 		// Create an attachment.
@@ -3534,6 +3530,8 @@ public function test_finalize_item_requires_auth(): void {
 	 * @covers WP_REST_Attachments_Controller::finalize_item
 	 */
 	public function test_finalize_item_invalid_id(): void {
+		$this->enable_client_side_media_processing();
+
 		wp_set_current_user( self::$author_id );
 
 		$invalid_id = PHP_INT_MAX;