[performance improvement] Vectorize Rayleigh–Ritz projection fallback#8
Open
singularitti wants to merge 1 commit into
Open
[performance improvement] Vectorize Rayleigh–Ritz projection fallback#8singularitti wants to merge 1 commit into
singularitti wants to merge 1 commit into
Conversation
Add rayleighRitzProduct to replace repeated MATLAB nested loops for building the Rayleigh-Ritz projection matrix with a BLAS-backed matrix multiply. Preserve the old upper-triangle-then-mirror behavior so the MATLAB fallback remains consistent with the existing MEX implementation.
singularitti
changed the title
singularitti
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the MATLAB fallback path for Rayleigh–Ritz projection construction.
Previously, several diagonalization routines built
Gwith nested MATLAB loops:This PR adds
rayleighRitzProduct, which computes:That keeps the same upper-triangle-then-mirror behavior while using MATLAB’s optimized matrix multiplication.
Updated call sites:
chefsi1.mchsubsp.mfirst_filt.mlanczos.mlanczosForChsubsp.mValidation
for j=1:m,for i=1:jindexing pattern.mmatches the relevant projected basis column count:n2ormev.Rayleighritz.c0-based loop logic.