Skip to content

[performance improvement] Vectorize Rayleigh–Ritz projection fallback #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
singularitti wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[performance improvement] Vectorize Rayleigh–Ritz projection fallback #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions RSDFT/DiagonalizationFiles/chefsi1.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,12 +47,7 @@
if (OPTIMIZATIONLEVEL~=0)
G=Rayleighritz(Vin,W,n2);
else
for j=1:n2
for i=1:j
G(i,j) = Vin(:,i)'*W(:,j);
G(j,i) = G(i,j);
end
end
G = rayleighRitzProduct(Vin,W);
if (enableMexFilesTest==1)
G2=Rayleighritz(Vin,W,n2);
if (any(abs(G-G2)>0.000001))
Expand Down
9 changes: 1 addition & 8 deletions RSDFT/DiagonalizationFiles/chsubsp.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,14 +47,7 @@
if (OPTIMIZATIONLEVEL~=0)
G=Rayleighritz(Vin,W,n2);
else
%preallocating G
G=zeros(n2,n2);
for j=1:n2
for i=1:j
G(i,j) = Vin(:,i)'*W(:,j);
G(j,i) = G(i,j);
end
end
G = rayleighRitzProduct(Vin,W);
if (enableMexFilesTest==1)
G2=Rayleighritz(Vin,W,n2);
if (any(abs(G-G2)>0.000001))
Expand Down
9 changes: 1 addition & 8 deletions RSDFT/DiagonalizationFiles/first_filt.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,14 +52,7 @@
if (OPTIMIZATIONLEVEL~=0)
G=Rayleighritz(Vin,W,n2);
else
% reuse G and overwrite it
G=zeros(n2,n2);
for j=1:n2
for i=1:j
G(i,j) = Vin(:,i)'*W(:,j);
G(j,i) = G(i,j);
end
end
G = rayleighRitzProduct(Vin,W);
end

[Q, D] = eig(G);
Expand Down
7 changes: 1 addition & 6 deletions RSDFT/DiagonalizationFiles/lanczos.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,12 +197,7 @@
if (OPTIMIZATIONLEVEL~=0)
G=Rayleighritz(Vin,W,mev);
else
for j=1:mev
for i=1:j
G(i,j) = Vin(:,i)'*W(:,j);
G(j,i) = G(i,j);
end
end
G = rayleighRitzProduct(Vin,W);
if (enableMexFilesTest==1)
G2=Rayleighritz(Vin,W,mev);
if (any(abs(G-G2)>0.000001))
Expand Down
7 changes: 1 addition & 6 deletions RSDFT/DiagonalizationFiles/lanczosForChsubsp.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,12 +172,7 @@
if (OPTIMIZATIONLEVEL~=0)
G=Rayleighritz(Vin,W,mev);
else
for j=1:mev
for i=1:j
G(i,j) = Vin(:,i)'*W(:,j);
G(j,i) = G(i,j);
end
end
G = rayleighRitzProduct(Vin,W);
if (enableMexFilesTest==1)
G2=Rayleighritz(Vin,W,mev);
if (any(abs(G-G2)>0.000001))
Expand Down
6 changes: 6 additions & 0 deletions RSDFT/DiagonalizationFiles/rayleighRitzProduct.m
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
function G = rayleighRitzProduct(Vin,W)
%% G = rayleighRitzProduct(Vin,W)
%% computes the same Rayleigh-Ritz projection as the old MATLAB loops.

G = Vin' * W;
G = triu(G) + triu(G,1)';