Restore processSolver after addModifier/removeModifier in SolverManagerFacet

The Phase 6 API migration (094525d) replaced addModifierAndSolve()
with addModifier() but omitted the follow-up processSolver() call that
recomputes the variable value. Without it, modifiers were registered but
never evaluated, causing GlobalModifyTest to hang waiting for a value
that was never computed.

Also short-circuit global-scope resolution: when the target scope is
global, call scopeFacet.getGlobalScope() directly instead of walking
the VarScoped hierarchy — global variables have no meaningful scoped
object to traverse.

In GlobalModifyTest.targetFacetCount(), guard against an empty diagnose
list (which is valid when no solver has been built yet) and remove a
stale comment about a missing API method.

Author: Vest

code/src/itest/tokencontent/GlobalModifyTest.java

@@ -98,11 +98,10 @@ protected int targetFacetCount()
 		try
 		{
 			List<?> list = sm.diagnose(varID);
-			size = list.size() - 1;
+			size = list.isEmpty() ? 0 : list.size() - 1;
 		}
 		catch (IllegalArgumentException e)
 		{
-			//Really, SolverManager should have isChannel(varID) to avoid diagnose complaining if something doesn't exist
 			size = 0;
 		}
 		return size;

code/src/java/pcgen/cdom/facet/SolverManagerFacet.java

@@ -49,10 +49,14 @@ public <T> List<ProcessStep<T>> diagnose(CharID id, VariableID<T> varID)
 	public <T> boolean addModifier(CharID id, VarModifier<T> vm, VarScoped thisValue, Modifier<T> modifier,
 		ScopeInstance source)
 	{
-		ScopeInstance scope = scopeFacet.get(id, vm.getFullLegalScopeName(), thisValue);
+		ScopeInstance scope = vm.getLegalScope().isGlobal()
+			? scopeFacet.getGlobalScope(id)
+			: scopeFacet.get(id, vm.getFullLegalScopeName(), thisValue);
 		VariableID<T> varID = (VariableID<T>) loadContextFacet.get(id.getDatasetID()).get().getVariableContext()
 			.getVariableID(scope, vm.getVarName());
-		get(id).addModifier(varID, modifier, source);
+		SolverManager sm = get(id);
+		sm.addModifier(varID, modifier, source);
+		sm.processSolver(varID);
 		return true;
 	}
 
@@ -62,10 +66,14 @@ public <T> boolean addModifier(CharID id, VarModifier<T> vm, VarScoped thisValue
 	public <T> void removeModifier(CharID id, VarModifier<T> vm, VarScoped thisValue, Modifier<T> modifier,
 		ScopeInstance source)
 	{
-		ScopeInstance scope = scopeFacet.get(id, vm.getFullLegalScopeName(), thisValue);
+		ScopeInstance scope = vm.getLegalScope().isGlobal()
+			? scopeFacet.getGlobalScope(id)
+			: scopeFacet.get(id, vm.getFullLegalScopeName(), thisValue);
 		VariableID<T> varID = (VariableID<T>) loadContextFacet.get(id.getDatasetID()).get().getVariableContext()
 			.getVariableID(scope, vm.getVarName());
-		get(id).removeModifier(varID, modifier, source);
+		SolverManager sm = get(id);
+		sm.removeModifier(varID, modifier, source);
+		sm.processSolver(varID);
 	}
 
 	public void setScopeFacet(ScopeFacet scopeFacet)