Added logging to catch invalid CHOOSE options#7321
Merged
Conversation
… item (The TemplateLst.java change) or as specified in CODE-103, a CHOOSE token is specified that has no corresponding template.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added some logs - they trigger if a data file has an invalid template item (The TemplateLst.java change) or as specified in CODE-103, a CHOOSE token is specified that has no corresponding template.
One limitation - if a CHOOSE token is VALID, but not REFERENCED, we can't detect it this way. that would require a recursive lookup to check if the valid token is also being accessed in the source and template and character - not easy, not consistent across systems, and not performant without fundamentally changing how the CDOM works.