Remove unused GMGen randomname i18n keys#7582
Merged
Merged
Conversation
`in_plugin_randomname_name` and `in_mn_plugin_randomname_name` were referenced only from `plugin/doomsdaybook/RandomNamePlugin.java`, the GMGen plugin wrapper that advertised the "Random Names" tab name and mnemonic. PR PCGen#7566 deleted that wrapper as part of the Random-name dialog Swing → JavaFX rewrite, and the live core dialog (`RandomNameDialog` → `RandomNamePanelController` + `RandomNamePanel.fxml`) doesn't expose a plugin-style tab label, so the keys have no replacement in core. Confirmed unused via `ScanForUnusedIl8nKeysTest` and a manual grep over `*.java`, `*.fxml`, `*.lst`. Removed from the four locale bundles that still carried them (en, es, fr, it; de/ja/pt already lacked them) and regenerated the `cleaned.properties` snapshot the scanner produces.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Delete two i18n keys that became dead weight after #7566:
in_plugin_randomname_name— "Random Name" / "Generador de Nombres" / etc.in_mn_plugin_randomname_name— single-letter mnemonic.Both were only ever referenced from
plugin/doomsdaybook/RandomNamePlugin.java, the GMGen plugin wrapper that advertised the "Random Names" tab name and mnemonic to GMGen's plugin host:#7566 (Random-name dialog: rewrite from Swing to JavaFX) deleted that wrapper as its first commit ("Remove dead RandomNamePlugin GMGen wrapper"). The live path is now
RandomNameDialog→RandomNamePanelController+RandomNamePanel.fxmlin core — no plugin tab label, no plugin-style mnemonic, no replacement key needed.The
_plugin_namespace was specific to GMGen plugin self-identification; core dialogs don't follow that convention.Verification
code/src/test/pcgen/gui2/ScanForUnusedIl8nKeysTestflagged the keys as unused after Random-name dialog: rewrite from Swing to JavaFX #7566 (visible in thecleaned.properties/unused.propertiessnapshots that drift on the working tree after the rewrite).*.java,*.fxml,*.lst, and other*.properties(excluding the bundle files themselves and the test snapshots): no references.LanguageBundle.properties(en),_es,_fr,_it._de,_ja,_ptalready lacked them.cleaned.propertiesvia./gradlew slowtest --tests pcgen.gui2.ScanForUnusedIl8nKeysTest.unused.propertiesis unchanged because the keys are now simply absent from the source bundle.Test plan
slowtest --tests pcgen.gui2.ScanForUnusedIl8nKeysTestpasses; snapshots up to date.