fix(tools): 自定义下载页加载时刷新按钮状态,避免下载按钮一直置灰#3353
Open
NoClassFoundError wants to merge 1 commit into
Open
Conversation
Contributor
审阅者指南(在小型 PR 上折叠)审阅者指南通过在 MeLoaded 期间验证下载 URL 并运行现有的开始按钮刷新逻辑,确保工具测试页面在加载时正确初始化下载按钮的启用/禁用状态。 MeLoaded 初始化下载按钮状态的时序图sequenceDiagram
actor User
participant PageToolsTest
participant TextDownloadFolder
participant TextDownloadName
participant TextDownloadUrl
participant BtnDownloadStart
User->>PageToolsTest: MeLoaded()
PageToolsTest->>TextDownloadFolder: Validate()
PageToolsTest->>TextDownloadName: Validate()
PageToolsTest->>TextDownloadUrl: Validate()
PageToolsTest->>PageToolsTest: StartButtonRefresh()
PageToolsTest->>BtnDownloadStart: [update IsEnabled based on validations]
文件级变更
与关联 issue 的对照评估
可能关联的 issue
使用技巧与命令与 Sourcery 交互
自定义你的使用体验访问你的 控制面板 以:
获取帮助Original review guide in EnglishReviewer's guide (collapsed on small PRs)Reviewer's GuideEnsures the tools test page initializes the download button enabled/disabled state correctly on load by validating the download URL and running the existing start-button refresh logic during MeLoaded. Sequence diagram for MeLoaded initializing download button statesequenceDiagram
actor User
participant PageToolsTest
participant TextDownloadFolder
participant TextDownloadName
participant TextDownloadUrl
participant BtnDownloadStart
User->>PageToolsTest: MeLoaded()
PageToolsTest->>TextDownloadFolder: Validate()
PageToolsTest->>TextDownloadName: Validate()
PageToolsTest->>TextDownloadUrl: Validate()
PageToolsTest->>PageToolsTest: StartButtonRefresh()
PageToolsTest->>BtnDownloadStart: [update IsEnabled based on validations]
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - 我已经审查了你的更改,看起来非常不错!
帮我变得更有用!请在每条评论上点 👍 或 👎,我会根据你的反馈改进后续的审查。
Original comment in English
Hey - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
RyogiMutsuki
approved these changes
Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PageToolsTest 的 MeLoaded 在加载时将 BtnDownloadStart 置为禁用,但既未校验 TextDownloadUrl,也未调用真正计算按钮启用状态的 StartButtonRefresh,导致下载按钮初始一直灰色、需手动改动下载地址(触发 ValidatedTextChanged→StartButtonRefresh)才会恢复。
在 MeLoaded 末尾补上TextDownloadUrl.Validate() 与 StartButtonRefresh(),使按钮在加载时即按 URL/文件夹/文件名三项校验结果正确启用/禁用。
resolves #3350
本PR的提交信息生成由Claude Code Opus 4.8生成,由Opus 4.8对代码进行了审查。
Summary by Sourcery
Bug Fixes:
Original summary in English
Summary by Sourcery
Bug Fixes: