fix: remove const from timeout_ms for WinHttpSetOption compatibility

Andrew Salas · Andrew Salas · commit a850ea2c2536 · 2026-04-17T13:24:31.000-07:00
diff --git a/common/HTTPDownloaderWinHTTP.cpp b/common/HTTPDownloaderWinHTTP.cpp
@@ -56,7 +56,7 @@ bool HTTPDownloaderWinHttp::Initialize(std::string user_agent)
 		return false;
 	}
 
-	const DWORD timeout_ms = 15000;
+	DWORD timeout_ms = 15000;
 	WinHttpSetOption(m_hSession, WINHTTP_OPTION_CONNECT_TIMEOUT, &timeout_ms, sizeof(timeout_ms));
 	WinHttpSetOption(m_hSession, WINHTTP_OPTION_SEND_TIMEOUT, &timeout_ms, sizeof(timeout_ms));
 	WinHttpSetOption(m_hSession, WINHTTP_OPTION_RECEIVE_TIMEOUT, &timeout_ms, sizeof(timeout_ms));

Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ bool HTTPDownloaderWinHttp::Initialize(std::string user_agent)`
`56`	`56`	`return false;`
`57`	`57`	`}`
`58`	`58`
`59`		`- const DWORD timeout_ms = 15000;`
	`59`	`+ DWORD timeout_ms = 15000;`
`60`	`60`	`WinHttpSetOption(m_hSession, WINHTTP_OPTION_CONNECT_TIMEOUT, &timeout_ms, sizeof(timeout_ms));`
`61`	`61`	`WinHttpSetOption(m_hSession, WINHTTP_OPTION_SEND_TIMEOUT, &timeout_ms, sizeof(timeout_ms));`
`62`	`62`	`WinHttpSetOption(m_hSession, WINHTTP_OPTION_RECEIVE_TIMEOUT, &timeout_ms, sizeof(timeout_ms));`