Skip to content

Qt: Re-arrange Display Settings layout#14247

Draft
kamfretoz wants to merge 1 commit into
PCSX2:masterfrom
kamfretoz:display-settings-refresh
Draft

Qt: Re-arrange Display Settings layout#14247
kamfretoz wants to merge 1 commit into
PCSX2:masterfrom
kamfretoz:display-settings-refresh

Conversation

@kamfretoz
Copy link
Copy Markdown
Contributor

Description of Changes

This PR re-arrange the display settings section to be more cleaner and more concise.

image

The Checkboxes in some section has also been given GroupBox as well to make them more tidy.

image

Rationale behind Changes

A more intuitive UI makes a better UX.

Suggested Testing Steps

Just make sure i didn't break any of the settings.

Did you use AI to help find, test, or implement this issue or feature?

Nope, just constant headbanging and fist-fight with Qt Widgets Designer.

@github-actions github-actions Bot added the GUI/Qt label Apr 3, 2026
@kamfretoz kamfretoz force-pushed the display-settings-refresh branch 2 times, most recently from 506b21c to fc7673b Compare April 4, 2026 14:35
@kamfretoz kamfretoz force-pushed the display-settings-refresh branch from fc7673b to 0297268 Compare April 17, 2026 17:20
@kamfretoz
Copy link
Copy Markdown
Contributor Author

rebased

Copy link
Copy Markdown
Contributor

@SternXD SternXD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kamfretoz kamfretoz force-pushed the display-settings-refresh branch 3 times, most recently from e82f92f to 3c92051 Compare April 25, 2026 16:42
@kamfretoz
Copy link
Copy Markdown
Contributor Author

kamfretoz commented Apr 25, 2026

Thanks to @chaoticgd's massive help, the crop spinboxes now uses way less space.

image

@kamfretoz kamfretoz force-pushed the display-settings-refresh branch 2 times, most recently from 6d8e87b to 96ee6f7 Compare April 25, 2026 17:48
@kamfretoz kamfretoz marked this pull request as draft April 25, 2026 18:05
@kamfretoz kamfretoz force-pushed the display-settings-refresh branch from 96ee6f7 to a46389c Compare April 26, 2026 13:51
@kamfretoz kamfretoz marked this pull request as ready for review April 26, 2026 13:51
@Pesa
Copy link
Copy Markdown
Contributor

Pesa commented Apr 28, 2026

Thanks to @chaoticgd's massive help, the crop spinboxes now uses way less space.

Honestly the previous version (the first screenshot in this PR) looks way better to me. Why so much space between "Crop:" on the left and the 4 spinboxes now? It feels disconnected.

Also, I think the group box is redundant if there's just one group of settings in a given tab. It doesn't provide any additional info to the user and it just clutters the UI. https://learn.microsoft.com/en-us/windows/win32/uxguide/ctrl-group-boxes

@F0bes
Copy link
Copy Markdown
Member

F0bes commented May 3, 2026

Thanks to @chaoticgd's massive help, the crop spinboxes now uses way less space.

Honestly the previous version (the first screenshot in this PR) looks way better to me. Why so much space between "Crop:" on the left and the 4 spinboxes now? It feels disconnected.

Also, I think the group box is redundant if there's just one group of settings in a given tab. It doesn't provide any additional info to the user and it just clutters the UI. learn.microsoft.com/en-us/windows/win32/uxguide/ctrl-group-boxes

Agreed, the spin boxes are in the wrong place. It's not intuitive.

@kamfretoz
Copy link
Copy Markdown
Contributor Author

Agreed, the spin boxes are in the wrong place. It's not intuitive.

Alright i'll revert it to how it looked on the original description.

@kamfretoz kamfretoz marked this pull request as draft May 4, 2026 23:38
@kamfretoz kamfretoz force-pushed the display-settings-refresh branch from a46389c to 295c29a Compare May 4, 2026 23:39
@kamfretoz kamfretoz force-pushed the display-settings-refresh branch from 295c29a to 3166c01 Compare May 4, 2026 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants