GS/HW: Add setting to do autoflush draws with a copy loop.#14305
Open
TJnotJT wants to merge 1 commit intoPCSX2:masterfrom
Open
GS/HW: Add setting to do autoflush draws with a copy loop.#14305TJnotJT wants to merge 1 commit intoPCSX2:masterfrom
TJnotJT wants to merge 1 commit intoPCSX2:masterfrom
Conversation
TJnotJT
force-pushed
the
gs-autoflush-detect
branch
8 times, most recently
from
ddd0cb7 to
e56e9a1
Compare
TJnotJT
force-pushed
the
gs-autoflush-detect
branch
3 times, most recently
from
68188d3 to
1a8b4ae
Compare
Only applies to certain autoflush draws.
TJnotJT
force-pushed
the
gs-autoflush-detect
branch
from
1a8b4ae to
91af850
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Add a new autoflush setting ("batched autoflush") to do autoflush draws with a copy loop.
Rationale behind Changes
Can reduce draws and improve performance in autoflush heavy games such as Jak 2 (dump attached).
Does not always improve stats/performance, as it can interact negatively with heuristics such as tex-is-fb, TC aging, early alpha test abort, etc.
Should not cause graphical regression, though it can cause tiny pixel difference (compared to standard autoflush) due to interactions with texel rounding and tex-is-fb heuristics.
Suggested Testing Steps
Enable the setting using GUI Settings>Graphics>Hardware Fixes>Auto Flush>Batch Enabled (after checking "Manual Hardware renderer Fixes" in Settings>Graphics>Rendering).
Alternatively, add the following to PCSX2.ini:
Try games known to be heavy on autoflush with any HW renderer.
Jak.II_SCUS-97265_20230303034214.gs.xz.zip
Did you use AI to help find, test, or implement this issue or feature?
Some questions about DX12 usage during debugging.