Qt: Revamp the status bar#14308
Conversation
kamfretoz
force-pushed
the
dropdown-statusbar
branch
from
3a4fc6e to
337c26b
Compare
kamfretoz
force-pushed
the
dropdown-statusbar
branch
4 times, most recently
from
23a0c69 to
0a79c84
Compare
kamfretoz
force-pushed
the
dropdown-statusbar
branch
from
0a79c84 to
91dc77b
Compare
chaoticgd
left a comment
chaoticgd
left a comment
There was a problem hiding this comment.
Had a look, found some issues.
I think the design here of bypassing the settings system and applying the changes directly, so that they are reset whenever the configuration is next updated, either from a reset or a setting being changed, is kind of odd.
I'd rather everything just go through the normal settings system and be synchronised with the settings in the config file.
|
I don't think is is a good idea to do , all this will do is ending up confusing users |
The idea is that i wanted to make it act like hotkeys where these changes made using the status bar dropdowns are only applied temporarily. |
kamfretoz
force-pushed
the
dropdown-statusbar
branch
from
91dc77b to
5079143
Compare
|
Rebased and addressed everything |
kamfretoz
force-pushed
the
dropdown-statusbar
branch
4 times, most recently
from
9356c35 to
394e267
Compare
Mrlinkwii
left a comment
Mrlinkwii
left a comment
There was a problem hiding this comment.
works very well with the appimage
kamfretoz
force-pushed
the
dropdown-statusbar
branch
from
394e267 to
43ab26b
Compare
|
Rebased, and also added small icons to the quick dropdown menu. |
| m_status_volume_slider->setRange(0, 100); | ||
| m_status_volume_slider->setFixedWidth(120); | ||
| m_status_volume_slider->setValue(Host::GetBaseIntSettingValue("SPU2/Output", "StandardVolume", 100)); | ||
| connect(m_status_volume_slider, &QSlider::valueChanged, [](int value) { |
There was a problem hiding this comment.
I'm still not happy about how this interacts with the settings system.
For example, if you tick "Mute All Sound" in the settings dialog, the unmute button in the status bar stops working, but if you drag on the slider in the status bar it starts playing sound again. And then if you change another audio setting like Buffer Size it mutes itself again.
If we're going to go forward with having it only apply temporarily we're going to need to decide what the source of truth should be.
There was a problem hiding this comment.
The hotkey just disables the volume options when it's muted from the settings dialog. So I guess you'd want to do that.
There was a problem hiding this comment.
If we're going to go forward with having it only apply temporarily we're going to need to decide what the source of truth should be.
Now that i think about it, i feel like its just easier to sync the volume on the status bar to the one on the settings, instead of making it ephemeral.
5 participants
Description of Changes
This PR revamps the Status bar and adds a few quick access dropdown menu to the frequently used options. (Renderer, volume, speed) and also added a GPU Usage monitor as well.
Rationale behind Changes
QoL Improvements. Easier to access these options when using the mouse.
Suggested Testing Steps
Test each dropdowns and see if they works. The changes done are temporary, meaning if you restart the VM the changes made will be gone.
Did you use AI to help find, test, or implement this issue or feature?
Nawh