GS/HW: Several barrier fixes, hw/sw blend, date and shuffles.#14349
Merged
lightningterror merged 5 commits intomasterfrom Apr 26, 2026
Merged
GS/HW: Several barrier fixes, hw/sw blend, date and shuffles.#14349lightningterror merged 5 commits intomasterfrom
lightningterror merged 5 commits intomasterfrom
Conversation
github-actions
Bot
added
GS
GS: Hardware
GS: Direct3D 11
GS: OpenGL
GS: Vulkan
GS: Direct3D 12
labels
lightningterror
force-pushed
the
gs_hw_barrier_fixes
branch
from
6a9a47d to
88244d9
Compare
lightningterror
force-pushed
the
gs_hw_barrier_fixes
branch
from
88244d9 to
ad95a14
Compare
lightningterror
force-pushed
the
gs_hw_barrier_fixes
branch
2 times, most recently
from
c536f70 to
ca83ff0
Compare
lightningterror
changed the title
lightningterror
changed the title
Add barrier fallback method.
- Accumulation blend: Require 32 bit RT is only when texture barriers/multidraw fb copies are on/supported. - Barrier DATE: Always use barrier date if texture barrier/multidraw fb copies are supported. Check if texture barriers/multidraw fb copies are supported before enabling barrier date for AA1.
lightningterror
force-pushed
the
gs_hw_barrier_fixes
branch
from
1700a24 to
5bd006f
Compare
lightningterror
force-pushed
the
gs_hw_barrier_fixes
branch
from
5bd006f to
5282869
Compare
Contributor
Author
|
Dump run clear on dx12, smoke tested affected dumps with and without texture barriers enabled on all renderers. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
GS/HW: Several barrier fixes to sw blend and barrier date.
Accumulation blend: Require 32 bit RT is only when texture barriers/multidraw fb copies are on/supported.
Barrier DATE: Always use barrier date if texture barrier/multidraw fb copies are supported.
Check if texture barriers/multidraw fb copies are supported before enabling barrier date for AA1.
GS/HW: Allow Date barrier when texture barriers/multidraw fb copies are disabled.
We still use copies for single barriers.
GS/HW: Clean up date stencil temp ds texture creation.
Add barrier fallback method.
GS/HW: Exclude shuffles for dst no rgb blend and no rt check.
GS/HW: Match TEXA behavior on shuffles between renderers.
Merge #14326 first before merging this one.
Rationale behind Changes
Bugfixes, regression fixes, optimizations.
Suggested Testing Steps
Test the dump below with texture barriers disabled on max blend:
Scarface Shadow.gs.xz.zip
Test other games that do a lot of shuffles.
Test games with and without texture barriers disabled such as persona 3/4 shadows, gt4 shadows, Sly 2, Amagami.
Test The Godfather dump and see if it's fixed on dx11/12:
The Godfather_SLUS-21385_20250529231536.gs.xz.zip
Test dumps from #11334
Did you use AI to help find, test, or implement this issue or feature?
No.