GS/HW: Sync rt copy behaviour across renderers.#14355
Merged
lightningterror merged 3 commits intomasterfrom May 1, 2026
Merged
GS/HW: Sync rt copy behaviour across renderers.#14355lightningterror merged 3 commits intomasterfrom
lightningterror merged 3 commits intomasterfrom
Conversation
github-actions
Bot
added
GS
GS: Direct3D 11
GS: OpenGL
GS: Vulkan
GS: Direct3D 12
labels
|
Will it help 2x-upscaled Need for Speed: Underground, Underground 2, Most Wanted etc. on my RTX 4050 laptop? |
Contributor
|
Could RenderHW and SendHW could be put in GSDevice and backend specific parts put in virtual functions (e.g. like the copy/barriers between feedback loops)? Maybe this is out of scope and would require a separate PR, but would help prevent divergence across renderers. |
lightningterror
force-pushed
the
gs_copy_behavior
branch
2 times, most recently
from
efaac46 to
9a05def
Compare
lightningterror
force-pushed
the
gs_copy_behavior
branch
from
9a05def to
c280498
Compare
Contributor
Author
|
I dunno some are similar like dx11 and gl between them, same for dx12 and vk, and the combined copy will further diverge from dx12/vk. |
Contributor
Author
|
Did a dump run on dx11 and smoke tested some dumps on dx11 and gl. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
GS/HW: Sync rt copy behaviour across renderers.
When multidraw fb copies and texture barriers are off make sure copies behave the same across all renderers.
Properly use one barrier param on dx11/gl, this will mirror texture barrier behaviour as it should, and gets rid of extra copies on dx11 when using alpha second pass.
When creating RT copies check if the barriers are from RT feedbacks because otherwise they might be from depth feedbacks and we don't need to copy the RT. This was observed on ZOE with accurate alpha test.
Rationale behind Changes
Bugfixes, optimizations.
Suggested Testing Steps
ZOE, and various dumps, test various games that use 2 pass alpha test, test all renderers with texture barriers enabled/disabled.
Did you use AI to help find, test, or implement this issue or feature?
No.