GS/Qt: Add librashader post-processing support#14433
Conversation
ff60b84 to
cc6d630
Compare
|
rebased and hopefully fixed librashader not working on CMake builds |
|
This is fantastic! Is there any chance you would be interested in adding this functionality to Dolphin or PPSSPP? Those are the last of the CRT era systems that have better standalone emulators than RetroArch cores and it would mean the world to me if they had proper shader support. If you didn't try the component video out dock for the PSP you were really missing out. |
|
Would you be open to upstreaming your patch to spirv-cross2 or allowing me to use your patch, if it is fixing a real bug? spirv-cross2 is not just meant for librashader, there are a couple of other projects that use it as well as ergonomic bindings to SPIRV-Cross in the Rust ecosystem. |
I can look at upstreaming it. |
|
|
Signed-off-by: SternXD <stern@sidestore.io>
Signed-off-by: SternXD <stern@sidestore.io>
Signed-off-by: SternXD <stern@sidestore.io> Co-authored-by: TheLastRar <TheLastRar@users.noreply.github.com>
Signed-off-by: SternXD <stern@sidestore.io>
Signed-off-by: SternXD <stern@sidestore.io>
Signed-off-by: SternXD <stern@sidestore.io>
Signed-off-by: SternXD <stern@sidestore.io>
Signed-off-by: SternXD <stern@sidestore.io>
Signed-off-by: SternXD <stern@sidestore.io>
Clear instead of invalidating to avoid undefined alpha being sampled by post-processing shaders. Signed-off-by: SternXD <stern@sidestore.io> Co-authored-by: chyyran <ronny@ronnychan.ca>
Signed-off-by: SternXD <stern@sidestore.io>
|
Reading through the librashader readme, they recommend using |
Probably. It's not something I really considered at first. If we went that route though, I don't think I'd be able to get it into the 2.8 cycle. |
Okay, so maybe that's an idea for a separate PR then. |
Personally I'm not a huge fan of the size of the librashader dependency in general and am trying to make it so we don't need it. |
Description of Changes
Settings > Post-Processing).slangpshader presets as post-processing, including a preset picker and runtime parameter controls.All in-game screenshots below are using the NewPixie CRT slang shader preset.
Settings page
BIOS
NFS MW 2005
Kingdom Hearts
Rationale behind Changes
Suggested Testing Steps
Settings > Post-Processing, enable librashader, pick a.slangppreset.Did you use AI to help find, test, or implement this issue or feature?
No.